You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Robert Stupp (JIRA)" <ji...@apache.org> on 2017/04/13 07:09:41 UTC

[jira] [Updated] (CASSANDRA-13443) V5 protocol flags decoding broken

     [ https://issues.apache.org/jira/browse/CASSANDRA-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Stupp updated CASSANDRA-13443:
-------------------------------------
    Status: Patch Available  (was: Open)

||cassandra-3.11|[branch|https://github.com/apache/cassandra/compare/cassandra-3.11...snazy:13443-proto-flags-3.11]|[testall|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-13443-proto-flags-3.11-testall/lastSuccessfulBuild/]|[dtest|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-13443-proto-flags-3.11-dtest/lastSuccessfulBuild/]
||trunk|[branch|https://github.com/apache/cassandra/compare/trunk...snazy:13443-proto-flags-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-13443-proto-flags-trunk-testall/lastSuccessfulBuild/]|[dtest|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-13443-proto-flags-trunk-dtest/lastSuccessfulBuild/]


> V5 protocol flags decoding broken
> ---------------------------------
>
>                 Key: CASSANDRA-13443
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13443
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Robert Stupp
>            Assignee: Robert Stupp
>            Priority: Minor
>
> Since native protocol version 5 we deserialize the flags in {{org.apache.cassandra.cql3.QueryOptions.Codec#decode}} as follows:
> {code}
>             EnumSet<Flag> flags = Flag.deserialize(version.isGreaterOrEqualTo(ProtocolVersion.V5)
>                                                    ? (int)body.readUnsignedInt()
>                                                    : (int)body.readByte());
> {code}
> This works until the highest bit (0x80) is not used. {{readByte}} must be changed to {{readUnsignedByte}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)