You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "afshing (via GitHub)" <gi...@apache.org> on 2023/12/28 19:32:07 UTC
[PR] init commit - no config [kafka]
afshing opened a new pull request, #15085:
URL: https://github.com/apache/kafka/pull/15085
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16042: Add byte-rate metrics for topic and partition [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #15085: KAFKA-16042: Add byte-rate metrics for topic and partition
URL: https://github.com/apache/kafka/pull/15085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16042: Add byte-rate metrics for topic and partition [kafka]
Posted by "ex172000 (via GitHub)" <gi...@apache.org>.
ex172000 commented on PR #15085:
URL: https://github.com/apache/kafka/pull/15085#issuecomment-1894726845
FYI: We are making a similar effort here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-977%3A+Partition-Level+Throughput+Metrics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16042: Add byte-rate metrics for topic and partition [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #15085:
URL: https://github.com/apache/kafka/pull/15085#issuecomment-2143682945
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) <p> If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16042: Add byte-rate metrics for topic and partition [kafka]
Posted by "echooymxq (via GitHub)" <gi...@apache.org>.
echooymxq commented on PR #15085:
URL: https://github.com/apache/kafka/pull/15085#issuecomment-1975225512
@afshing Where is the pr for [KAFKA-16044](https://issues.apache.org/jira/browse/KAFKA-16044) ? I'm interested in your implementation of the topic quota.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16042: Add byte-rate metrics for topic and partition [kafka]
Posted by "afshing (via GitHub)" <gi...@apache.org>.
afshing commented on PR #15085:
URL: https://github.com/apache/kafka/pull/15085#issuecomment-1907026805
> FYI: We are making a similar effort here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-977%3A+Partition-Level+Throughput+Metrics
@ex172000 thanks for your comment.
Your work is definitely more dedicated customization over exposing topic-partition metrics, which is great.
In our fork, we exposed the byte-rate and throttle-time metrics per topic-partition to use that for quota management based on topic-partition (see [KIP-1010](https://cwiki.apache.org/confluence/display/KAFKA/KIP-1010%3A+Topic+Partition+Quota), without giving any option to disable/enable it or customize its level verbosity.
With this proposal, it makes more sense for us to port our quota management change over this format.
I have two questions:
1. What is the status of this KIP. Is it something that you have used in your fork and trying to contribute to the upstream, or it is a new implementation (try to get a sense of how much work is remained)
2. We don't have any discussion initiated on our KIP-1010. But, I see your KIP-977 is approved, but I can't find any discussion in [the thread](https://lists.apache.org/list?dev@kafka.apache.org:lte=1M:KIP-977). I am wondering what is the KIP life-cycle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16042: Add byte-rate metrics for topic and partition [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #15085:
URL: https://github.com/apache/kafka/pull/15085#issuecomment-2571488479
This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org