You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Leif Hedstrom (JIRA)" <ji...@apache.org> on 2012/07/10 04:16:35 UTC
[jira] [Created] (TS-1339) Offset table is not accounting for
multiple alternate documents
Leif Hedstrom created TS-1339:
---------------------------------
Summary: Offset table is not accounting for multiple alternate documents
Key: TS-1339
URL: https://issues.apache.org/jira/browse/TS-1339
Project: Traffic Server
Issue Type: Bug
Components: Cache
Affects Versions: 3.2.0
Reporter: Leif Hedstrom
Priority: Critical
Fix For: 3.3.0
This was discovered by Wei Jin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (TS-1339) Offset table is not accounting
for multiple alternate documents
Posted by "Alan M. Carroll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424482#comment-13424482 ]
Alan M. Carroll edited comment on TS-1339 at 7/29/12 3:31 AM:
--------------------------------------------------------------
I tested this and it doesn't work correctly. It will prevent acceleration even of objects with a single alternate. This is because an object that is large can be migrated to the alternate set during a refresh even if it is a single alternate. Once that happens this patch will prevent range acceleration on that object despite it being safe.
For example on a test file I had a doc->key of D59D23CE, a next key of ADA5047B, and an earliest key of 598A1037 with a single alternate, which fails the test.
was (Author: amc):
I tested this and it doesn't work correctly. It will prevent acceleration even of objects with a single alternate. This is because an object that is large can be migrated to the alternate set during a refresh even if it is a single alternate. Once that happens this patch will prevent range acceleration on that object despite it being safe.
> Offset table is not accounting for multiple alternate documents
> ---------------------------------------------------------------
>
> Key: TS-1339
> URL: https://issues.apache.org/jira/browse/TS-1339
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache
> Affects Versions: 3.2.0
> Reporter: Leif Hedstrom
> Assignee: John Plevyak
> Priority: Critical
> Fix For: 3.3.1
>
> Attachments: TS-1339.try3.diff
>
>
> This was discovered by Wei Jin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1339) Offset table is not accounting for
multiple alternate documents
Posted by "Alan M. Carroll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416360#comment-13416360 ]
Alan M. Carroll commented on TS-1339:
-------------------------------------
As a temporary measure I have a patch that lets the SM check for pread capability in the VC and fallback to the transform style range servicing if the VC is not capable. The method returns "no pread" if there is more than 1 alternate.
Commit: b300e76dfba553ec7912831a78084e1bce2d38cf
> Offset table is not accounting for multiple alternate documents
> ---------------------------------------------------------------
>
> Key: TS-1339
> URL: https://issues.apache.org/jira/browse/TS-1339
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache
> Affects Versions: 3.2.0
> Reporter: Leif Hedstrom
> Assignee: John Plevyak
> Priority: Critical
> Fix For: 3.3.0
>
>
> This was discovered by Wei Jin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1339) Offset table is not accounting for
multiple alternate documents
Posted by "weijin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420430#comment-13420430 ]
weijin commented on TS-1339:
----------------------------
this patch have some serious bugs:
1: od should be protected by vol`s lock.
2: I think od is just used to read_from_writer (or remove), if there is no writer, the od will be null.
> Offset table is not accounting for multiple alternate documents
> ---------------------------------------------------------------
>
> Key: TS-1339
> URL: https://issues.apache.org/jira/browse/TS-1339
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache
> Affects Versions: 3.2.0
> Reporter: Leif Hedstrom
> Assignee: John Plevyak
> Priority: Critical
> Fix For: 3.3.1
>
>
> This was discovered by Wei Jin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1339) Offset table is not accounting for
multiple alternate documents
Posted by "Alan M. Carroll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420762#comment-13420762 ]
Alan M. Carroll commented on TS-1339:
-------------------------------------
I put in a patch that seems to work for me (it no longer crashes, and accelerates when appropriate). I will try to look at moving the offset table.
> Offset table is not accounting for multiple alternate documents
> ---------------------------------------------------------------
>
> Key: TS-1339
> URL: https://issues.apache.org/jira/browse/TS-1339
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache
> Affects Versions: 3.2.0
> Reporter: Leif Hedstrom
> Assignee: John Plevyak
> Priority: Critical
> Fix For: 3.3.1
>
>
> This was discovered by Wei Jin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1339) Offset table is not accounting for
multiple alternate documents
Posted by "weijin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
weijin updated TS-1339:
-----------------------
Attachment: TS-1339.try4.diff
amc found a serious bug in previous patch, that when do a cache update (total_len = 0), the doc->key is changed as the random earliest_key.
I change it by using the update_key. It seems works, but I need more reviews.
Thanks for all your advices.
> Offset table is not accounting for multiple alternate documents
> ---------------------------------------------------------------
>
> Key: TS-1339
> URL: https://issues.apache.org/jira/browse/TS-1339
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache
> Affects Versions: 3.2.0
> Reporter: Leif Hedstrom
> Assignee: John Plevyak
> Priority: Critical
> Fix For: 3.3.1
>
> Attachments: TS-1339.try3.diff, TS-1339.try4.diff
>
>
> This was discovered by Wei Jin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1339) Offset table is not accounting for
multiple alternate documents
Posted by "weijin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420571#comment-13420571 ]
weijin commented on TS-1339:
----------------------------
we can not call do_io_pread for range servicing even if there is only one alternate.
e.g.
client: first_request (no doc), do write (offset table account for this doc (alternate)
client: second_request but not match, do update (now the offset table account for the second doc (alternate)
....
in some special conditions, the second doc (alternate) will be deleted if we found it is truncated. (now, the offset table account for nothing)
> Offset table is not accounting for multiple alternate documents
> ---------------------------------------------------------------
>
> Key: TS-1339
> URL: https://issues.apache.org/jira/browse/TS-1339
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache
> Affects Versions: 3.2.0
> Reporter: Leif Hedstrom
> Assignee: John Plevyak
> Priority: Critical
> Fix For: 3.3.1
>
>
> This was discovered by Wei Jin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-1339) Offset table is not accounting for
multiple alternate documents
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom reassigned TS-1339:
---------------------------------
Assignee: John Plevyak
> Offset table is not accounting for multiple alternate documents
> ---------------------------------------------------------------
>
> Key: TS-1339
> URL: https://issues.apache.org/jira/browse/TS-1339
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache
> Affects Versions: 3.2.0
> Reporter: Leif Hedstrom
> Assignee: John Plevyak
> Priority: Critical
> Fix For: 3.3.0
>
>
> This was discovered by Wei Jin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1339) Offset table is not accounting for
multiple alternate documents
Posted by "Alan M. Carroll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan M. Carroll updated TS-1339:
--------------------------------
Attachment: ts-1339.diff
Move range offset table to the alt header.
> Offset table is not accounting for multiple alternate documents
> ---------------------------------------------------------------
>
> Key: TS-1339
> URL: https://issues.apache.org/jira/browse/TS-1339
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache
> Affects Versions: 3.2.0
> Reporter: Leif Hedstrom
> Assignee: John Plevyak
> Priority: Critical
> Fix For: 3.3.1
>
> Attachments: ts-1339.diff, TS-1339.try3.diff, TS-1339.try4.diff
>
>
> This was discovered by Wei Jin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1339) Offset table is not accounting for
multiple alternate documents
Posted by "weijin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
weijin updated TS-1339:
-----------------------
Attachment: TS-1339.try3.diff
identify the offset table by checking the relationship of alternate`s key and the earliest_key.
> Offset table is not accounting for multiple alternate documents
> ---------------------------------------------------------------
>
> Key: TS-1339
> URL: https://issues.apache.org/jira/browse/TS-1339
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache
> Affects Versions: 3.2.0
> Reporter: Leif Hedstrom
> Assignee: John Plevyak
> Priority: Critical
> Fix For: 3.3.1
>
> Attachments: TS-1339.try3.diff
>
>
> This was discovered by Wei Jin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1339) Offset table is not accounting for
multiple alternate documents
Posted by "weijin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420580#comment-13420580 ]
weijin commented on TS-1339:
----------------------------
what I want to do is move the offset table into alternate, which means for http, offset table is not in Doc but in alternate. but this is more complex.
AMC, Leif: what`s your option.
> Offset table is not accounting for multiple alternate documents
> ---------------------------------------------------------------
>
> Key: TS-1339
> URL: https://issues.apache.org/jira/browse/TS-1339
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache
> Affects Versions: 3.2.0
> Reporter: Leif Hedstrom
> Assignee: John Plevyak
> Priority: Critical
> Fix For: 3.3.1
>
>
> This was discovered by Wei Jin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1339) Offset table is not accounting for
multiple alternate documents
Posted by "Alan M. Carroll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424482#comment-13424482 ]
Alan M. Carroll commented on TS-1339:
-------------------------------------
I tested this and it doesn't work correctly. It will prevent acceleration even of objects with a single alternate. This is because an object that is large can be migrated to the alternate set during a refresh even if it is a single alternate. Once that happens this patch will prevent range acceleration on that object despite it being safe.
> Offset table is not accounting for multiple alternate documents
> ---------------------------------------------------------------
>
> Key: TS-1339
> URL: https://issues.apache.org/jira/browse/TS-1339
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache
> Affects Versions: 3.2.0
> Reporter: Leif Hedstrom
> Assignee: John Plevyak
> Priority: Critical
> Fix For: 3.3.1
>
> Attachments: TS-1339.try3.diff
>
>
> This was discovered by Wei Jin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1339) Offset table is not accounting for
multiple alternate documents
Posted by "Alan M. Carroll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428141#comment-13428141 ]
Alan M. Carroll commented on TS-1339:
-------------------------------------
That doesn't work for me either. I think it is fundamentally not going to be successful because the structure is identical for both cases. The only option I can think of at this point is to detect the addition of the second alternate and drop the frag table at that point.
> Offset table is not accounting for multiple alternate documents
> ---------------------------------------------------------------
>
> Key: TS-1339
> URL: https://issues.apache.org/jira/browse/TS-1339
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache
> Affects Versions: 3.2.0
> Reporter: Leif Hedstrom
> Assignee: John Plevyak
> Priority: Critical
> Fix For: 3.3.1
>
> Attachments: TS-1339.try3.diff, TS-1339.try4.diff
>
>
> This was discovered by Wei Jin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1339) Offset table is not accounting for
multiple alternate documents
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420653#comment-13420653 ]
Leif Hedstrom commented on TS-1339:
-----------------------------------
We all agreed that the long term fix is to move the offset table. The hope was that eliminating the pread() could be a stop-gap solution, but looks like it might not. The other solution is to disable this optimization completely for v3.2.x, until we can move the offset table?
> Offset table is not accounting for multiple alternate documents
> ---------------------------------------------------------------
>
> Key: TS-1339
> URL: https://issues.apache.org/jira/browse/TS-1339
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache
> Affects Versions: 3.2.0
> Reporter: Leif Hedstrom
> Assignee: John Plevyak
> Priority: Critical
> Fix For: 3.3.1
>
>
> This was discovered by Wei Jin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira