You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by su...@apache.org on 2018/02/07 23:37:45 UTC
groovy git commit: Trivial refactoring: Refine `getMethodDescriptor`
Repository: groovy
Updated Branches:
refs/heads/master 714abf2c9 -> 7c4aebb17
Trivial refactoring: Refine `getMethodDescriptor`
Project: http://git-wip-us.apache.org/repos/asf/groovy/repo
Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/7c4aebb1
Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/7c4aebb1
Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/7c4aebb1
Branch: refs/heads/master
Commit: 7c4aebb17e9d3ae5559f8b9a76d84f58c3b42276
Parents: 714abf2
Author: sunlan <su...@apache.org>
Authored: Thu Feb 8 07:37:39 2018 +0800
Committer: sunlan <su...@apache.org>
Committed: Thu Feb 8 07:37:39 2018 +0800
----------------------------------------------------------------------
.../codehaus/groovy/classgen/asm/BytecodeHelper.java | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/groovy/blob/7c4aebb1/src/main/java/org/codehaus/groovy/classgen/asm/BytecodeHelper.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/codehaus/groovy/classgen/asm/BytecodeHelper.java b/src/main/java/org/codehaus/groovy/classgen/asm/BytecodeHelper.java
index af464f4..197ac9c 100644
--- a/src/main/java/org/codehaus/groovy/classgen/asm/BytecodeHelper.java
+++ b/src/main/java/org/codehaus/groovy/classgen/asm/BytecodeHelper.java
@@ -75,9 +75,10 @@ public class BytecodeHelper implements Opcodes {
}
public static String getMethodDescriptor(ClassNode returnType, Parameter[] parameters) {
- StringBuilder buffer = new StringBuilder("(");
- for (int i = 0; i < parameters.length; i++) {
- buffer.append(getTypeDescription(parameters[i].getType()));
+ StringBuilder buffer = new StringBuilder(100);
+ buffer.append("(");
+ for (Parameter parameter : parameters) {
+ buffer.append(getTypeDescription(parameter.getType()));
}
buffer.append(")");
buffer.append(getTypeDescription(returnType));
@@ -99,9 +100,10 @@ public class BytecodeHelper implements Opcodes {
*/
public static String getMethodDescriptor(Class returnType, Class[] paramTypes) {
// lets avoid class loading
- StringBuilder buffer = new StringBuilder("(");
- for (int i = 0; i < paramTypes.length; i++) {
- buffer.append(getTypeDescription(paramTypes[i]));
+ StringBuilder buffer = new StringBuilder(100);
+ buffer.append("(");
+ for (Class paramType : paramTypes) {
+ buffer.append(getTypeDescription(paramType));
}
buffer.append(")");
buffer.append(getTypeDescription(returnType));