[jira] [Resolved] (HBASE-27539) Encapsulate and centralise access to ref count through StoreFileInfo

["Tak-Lon (Stephen) Wu (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-27539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tak-Lon (Stephen) Wu resolved HBASE-27539.
------------------------------------------
    Fix Version/s:     (was: 2.5.3)
     Hadoop Flags: Reviewed
       Resolution: Fixed

thanks everyone, I have reverted it on branch-2.5 as of [#392bc972eb5943536ac5ea4b1e9b16b3f7c51d89|https://github.com/apache/hbase/commit/392bc972eb5943536ac5ea4b1e9b16b3f7c51d89]

> Encapsulate and centralise access to ref count through StoreFileInfo
> --------------------------------------------------------------------
>
>                 Key: HBASE-27539
>                 URL: https://issues.apache.org/jira/browse/HBASE-27539
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 3.0.0-alpha-3
>            Reporter: chenglei
>            Assignee: chenglei
>            Priority: Major
>             Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> Both {{StoreFileReader}} and {{StoreFileInfo}} have  a {{refCount}}, and the {{refCount}} is currently used in three main ways:
> * When a new {{StoreFileScanner}} is created or close, it increases  or decreases the {{StoreFileReader.refCount}}.
> * When {{CompactedHFilesDischarger}}  checks a {{HStoreFile}} whether it could be deleted, it check the {{StoreFileInfo.refCount}}.
> * When {{HStore.getScanners}} gets {{HStoreFile}} from {{StoreFileManager}}, it  increases  or decreases the {{StoreFileInfo.refCount}}.
> The problem here is  {{StoreFileReader.refCount}}  is copied from the {{StoreFileInfo.refCount}}  and the inconsistent usage of the {{refCount}} making the code somewhat hard to understand and causing trace the resource race problems such as HBASE-27484 and HBASE-27519 somewhat difficult. I suggest we should unify these two {{refCount}} and just use {{StoreFileInfo.refCount}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)