You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Martin Kočí (JIRA)" <de...@myfaces.apache.org> on 2011/06/01 21:33:47 UTC

[jira] [Commented] (MYFACES-3157) Fix order of isRendered and pushComponentToEL invocations

    [ https://issues.apache.org/jira/browse/MYFACES-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042381#comment-13042381 ] 

Martin Kočí commented on MYFACES-3157:
--------------------------------------

This affects methods visitTree too: specification says "UIComponent.visitTree() implementations must call UIComponent.pushComponentToEL() before performing the visit and UIComponent.popComponentFromEL() after the visit." - methos isVisitable reads "rendered" property. 

> Fix order of isRendered and pushComponentToEL invocations
> ---------------------------------------------------------
>
>                 Key: MYFACES-3157
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3157
>             Project: MyFaces Core
>          Issue Type: Bug
>         Environment: myfaces core trunk
>            Reporter: Martin Kočí
>         Attachments: myfaces-api-MYFACES-3157-v1.patch
>
>
> Current specification for lifecycles methods:
> 1) processDecodes
> 2) processValidators
> 3) processUpdates
> 4) encodeAll
> 4) encodeBegin
> explicitly says that:
> 1) If the rendered property of this UIComponent is false, skip further processing.
> 2) call pushComponentToEL
> But in that order of invocations it is impossible to achieve rendered like this:
> <h:outputText rendered="#{component.id eq 'outputTextId'}" id="outputTextId" />
> i.e. any rendered ValueEpression based on component itself. In Myfaces  we should implement in in reverse order, because specified behaviour is buggy.
> Please see this mail thread: http://www.mail-archive.com/dev@myfaces.apache.org/msg53300.html
> and
> http://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-1002
> for details.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira