You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "stevenzwu (via GitHub)" <gi...@apache.org> on 2023/06/28 23:16:25 UTC
[GitHub] [iceberg] stevenzwu commented on a diff in pull request #7936: Core: add missing start and length for FileScanTaskParser.
stevenzwu commented on code in PR #7936:
URL: https://github.com/apache/iceberg/pull/7936#discussion_r1245910051
##########
core/src/main/java/org/apache/iceberg/FileScanTaskParser.java:
##########
@@ -33,6 +33,8 @@ public class FileScanTaskParser {
private static final String SCHEMA = "schema";
private static final String SPEC = "spec";
private static final String DATA_FILE = "data-file";
+ private static final String START = "start";
Review Comment:
I call it `start` to match the `FileScanTask/ContentScantask` method name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org