Re: [PR] feat(pyamber): align VFS resource wire values [texera]

["carloea2 (via GitHub)" <gi...@apache.org>]

carloea2 commented on code in PR #8238:
URL: https://github.com/apache/texera/pull/8238#discussion_r3972254036


##########
amber/src/main/python/core/storage/vfs_uri_factory.py:
##########
@@ -88,7 +88,7 @@ def extract_value(key: str) -> str:
             else None
         )
 
-        resource_type_str = segments[-1].lower()
+        resource_type_str = segments[-1]

Review Comment:
   Updated as suggested. The enum now uses the lowercase Scala wire values, the decoder keeps lowercase normalization, and the test uses literal wire suffixes. I also corrected #8237.



##########
amber/src/main/python/core/storage/vfs_uri_factory.py:
##########
@@ -88,7 +88,7 @@ def extract_value(key: str) -> str:
             else None
         )
 
-        resource_type_str = segments[-1].lower()
+        resource_type_str = segments[-1]
         try:
             resource_type = VFSResourceType(resource_type_str)
         except ValueError:

Review Comment:
   Kept the existing lowercase normalization and aligned the enum values with the wire format.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org