You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/18 21:13:27 UTC
[GitHub] [arrow] lidavidm opened a new issue, #33767: [Go] Exported ArrowArrayStream.get_next doesn't handle uninitialized ArrowArrays well
lidavidm opened a new issue, #33767:
URL: https://github.com/apache/arrow/issues/33767
### Describe the bug, including details regarding any error messages, version, and platform.
`get_next` should set `ArrowArray.release` to `NULL` when there are no more records. However, the current implementation instead tries to _release_ the out-parameter. This is harmless when the out-parameter is 0-initialized (the implementation will skip the call) but otherwise it'll crash (after jumping to a random garbage address).
### Component(s)
Go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on issue #33767: [Go] Exported ArrowArrayStream.get_next doesn't handle uninitialized ArrowArrays well
Posted by GitBox <gi...@apache.org>.
lidavidm commented on issue #33767:
URL: https://github.com/apache/arrow/issues/33767#issuecomment-1397265138
That's what I thought :)
(It was expecting it to be zero-initialized, because it would _call the release callback if present_.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on issue #33767: [Go] Exported ArrowArrayStream.get_next doesn't handle uninitialized ArrowArrays well
Posted by GitBox <gi...@apache.org>.
lidavidm commented on issue #33767:
URL: https://github.com/apache/arrow/issues/33767#issuecomment-1396121047
@pitrou I noticed this while using PyArrow to import an ArrowArrayStream exported from Go. PyArrow apparently passes in an uninitialized ArrowArray to Go, and Go was assuming it would be initialized. Should we say that producers should not assume inputs are initialized, or that consumers should (zero-)initialize parameters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed issue #33767: [Go] Exported ArrowArrayStream.get_next doesn't handle uninitialized ArrowArrays well
Posted by GitBox <gi...@apache.org>.
lidavidm closed issue #33767: [Go] Exported ArrowArrayStream.get_next doesn't handle uninitialized ArrowArrays well
URL: https://github.com/apache/arrow/issues/33767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on issue #33767: [Go] Exported ArrowArrayStream.get_next doesn't handle uninitialized ArrowArrays well
Posted by GitBox <gi...@apache.org>.
pitrou commented on issue #33767:
URL: https://github.com/apache/arrow/issues/33767#issuecomment-1397255508
The `out` parameter should be handled as an out-parameter, so it can't be expected to be initialized (to what?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org