You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/04/26 03:57:17 UTC

[GitHub] [camel-k] tadayosi opened a new pull request, #3235: WIP - feat(CRD): Traits configuration schema

tadayosi opened a new pull request, #3235:
URL: https://github.com/apache/camel-k/pull/3235

   <!-- Description -->
   
   This addresses #1614. This tries to restore the unmerged pull req #1624.
   
   > This PR moves the traits configuration into the API. This enables the generation of the openAPI schema for the traits configuration into the Integration, IntegrationPlatform and IntegrationKit CRDs.
   
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   feat(CRD): Traits configuration schema
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] tadayosi merged pull request #3235: feat(CRD): Traits configuration schema

Posted by GitBox <gi...@apache.org>.
tadayosi merged PR #3235:
URL: https://github.com/apache/camel-k/pull/3235


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] tadayosi commented on pull request #3235: feat(CRD): Traits configuration schema

Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3235:
URL: https://github.com/apache/camel-k/pull/3235#issuecomment-1178594075

   Thanks!  OK, let me go ahead and merge...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] tadayosi commented on pull request #3235: WIP - feat(CRD): Traits configuration schema

Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3235:
URL: https://github.com/apache/camel-k/pull/3235#issuecomment-1111715225

   One more issue to address is that the addons are not listed in the `Traits` struct. We need to find a way to extend Traits from addons.
   
   One option would be to add an `Addons` struct along with the `Traits`, which would serialise as a list of `RawMessage` (as traits currently), and have a mechanism to contribute/update the CRD with the addon structural schema.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] tadayosi commented on pull request #3235: WIP - feat(CRD): Traits configuration schema

Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3235:
URL: https://github.com/apache/camel-k/pull/3235#issuecomment-1110675195

   The main part is done. Now I'll see and fix what makes the e2e tests fail.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] tadayosi commented on pull request #3235: feat(CRD): Traits configuration schema

Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3235:
URL: https://github.com/apache/camel-k/pull/3235#issuecomment-1174952876

   The `openshift-build` workflow is failing at known flaky tests, which should be irrelevant to this pull req.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org