[GitHub] joey commented on a change in pull request #6862: [FLINK-10213] Task managers cache a negative DNS lookup of the blob server indefinitely

[GitBox <gi...@apache.org>]

joey commented on a change in pull request #6862: [FLINK-10213] Task managers cache a negative DNS lookup of the blob server indefinitely
URL: https://github.com/apache/flink/pull/6862#discussion_r240664268
 
 

 ##########
 File path: flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientTest.java
 ##########
 @@ -487,4 +487,11 @@ private static void uploadJarFile(
 			validateGetAndClose(blobClient.getInternal(jobId, blobKeys.get(0)), testFile);
 		}
 	}
+
+	@Test
+	public void testUnresolvedInetSocketAddress() throws Exception {
+		try (BlobClient client = new BlobClient(
+			InetSocketAddress.createUnresolved("localhost", getBlobServer().getPort()), getBlobClientConfig())) {
+		}
 
 Review comment:
   I'm adding a new method to BlobClient to check if the socket is connected and then adding an assert here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services