[GitHub] [jackrabbit-oak] fabriziofortino commented on a change in pull request #498: OAK-9694: expose elastic stats in oak-index-stats and mbean

[GitBox <gi...@apache.org>]

fabriziofortino commented on a change in pull request #498:
URL: https://github.com/apache/jackrabbit-oak/pull/498#discussion_r811292239



##########
File path: oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/spi/editor/FulltextIndexEditorContext.java
##########
@@ -165,9 +164,8 @@ public void closeWriter() throws IOException {
       NodeBuilder status = definitionBuilder.child(IndexDefinition.STATUS_NODE);
       status.setProperty(IndexDefinition.STATUS_LAST_UPDATED, getUpdatedTime(currentTime), Type.DATE);
       status.setProperty("indexedNodes", indexedNodes);
-      if (storedIndexDefinitionEnabled() && reindex) {
-        NodeBuilder indexDefinition = definitionBuilder.child(STATUS_NODE);
-        indexDefinition.setProperty(IndexDefinition.REINDEX_COMPLETION_TIMESTAMP, ISO8601.format(currentTime), Type.DATE);
+      if (reindex) {

Review comment:
       the reindex completion timestamp is exposed in the index stats. I could not find a reason why this was not set for NON stored index defs. I don't see issues in setting it in any case. Feedback is welcome @thomasmueller @nit0906 @averma21 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org