You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/24 22:29:09 UTC
[GitHub] [airflow-client-go] senthilkumarkj opened a new pull request #21: Fix parsing of ScheduleInterval
senthilkumarkj opened a new pull request #21:
URL: https://github.com/apache/airflow-client-go/pull/21
__type is a common field in all the allowed types, so schedule interval
will never be `{}`. So we can't compare against empty struct alone to
find if we've the right type. We need to look into the `__type` value
to find the correct struct.
Fixes #20.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-go] senthilkumarkj commented on pull request #21: Fix parsing of ScheduleInterval
Posted by GitBox <gi...@apache.org>.
senthilkumarkj commented on pull request #21:
URL: https://github.com/apache/airflow-client-go/pull/21#issuecomment-1078568678
I see the comment `Code generated by OpenAPI Generator (https://openapi-generator.tech); DO NOT EDIT.`
Is there another way to fix this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-go] DrFaust92 commented on pull request #21: Fix parsing of ScheduleInterval
Posted by GitBox <gi...@apache.org>.
DrFaust92 commented on pull request #21:
URL: https://github.com/apache/airflow-client-go/pull/21#issuecomment-1079775047
@senthilkumarkj the API Spec can be found here https://github.com/apache/airflow/blob/main/airflow/api_connexion/openapi/v1.yaml
and Info on client gen is here:
https://github.com/apache/airflow/tree/main/clients
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-go] houqp commented on pull request #21: Fix parsing of ScheduleInterval
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #21:
URL: https://github.com/apache/airflow-client-go/pull/21#issuecomment-1079798055
Yep, what @DrFaust92 said, these generated code is not supposed to be edit manually, we need to either fix the openapi spec or fix openapi-generator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-go] senthilkumarkj commented on pull request #21: Fix parsing of ScheduleInterval
Posted by GitBox <gi...@apache.org>.
senthilkumarkj commented on pull request #21:
URL: https://github.com/apache/airflow-client-go/pull/21#issuecomment-1084082874
New PR https://github.com/apache/airflow/pull/22635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-go] senthilkumarkj commented on pull request #21: Fix parsing of ScheduleInterval
Posted by GitBox <gi...@apache.org>.
senthilkumarkj commented on pull request #21:
URL: https://github.com/apache/airflow-client-go/pull/21#issuecomment-1083474896
Thank you all and sorry for the delayed response.
I think the issue is in this line - https://github.com/apache/airflow/blob/main/airflow/api_connexion/openapi/v1.yaml#L3351
Based on [this](https://redocly.com/docs/resources/discriminator/#oneof-vs-anyof), we should be using `anyOf` as the json matches more than one schema. I'll send a CL out. In the meantime, please correct me if my understanding is wrong. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org