You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/12 08:50:54 UTC

[GitHub] [flink] twalthr commented on a change in pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

twalthr commented on a change in pull request #17439:
URL: https://github.com/apache/flink/pull/17439#discussion_r726903584



##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/BuiltInFunctionTestBase.java
##########
@@ -411,7 +411,7 @@ public String toString() {
             return "[API] "
                     + expression.stream()
                             .map(Expression::asSummaryString)
-                            .collect(Collectors.joining());
+                            .collect(Collectors.joining(", "));

Review comment:
       changes in test bases that are unrelated to the PR, should be moved in a hotfix commit. this way a committer can still merge this, even if we discard the main commit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org