You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avalon.apache.org by Sylvain Wallez <sy...@anyware-tech.com> on 2003/01/18 23:47:29 UTC

[logkit][patch] A Swing GUI for logkit

Hi,

A few months ago, LogFactor5, a commercial Swing GUI for log4j was 
donated to the log4j project. But this GUI is actually logging-system 
agnostic, so I wrote a brigde for logkit.

You can see it in action with Cocoon at 
http://cvs.apache.org/~sylvain/lf5/lf5-logkit.gif

Please find attached :
- lf5-logkit.zip : content of the new org.apache.log.output.lf5 package 
for logkit,
- LF5TargetFactory.java : new target factory for excalibur-logger.

Logkit's build also requires some changes, but I wasn't able to diff it 
because there seems to be some line ending problems on what's stored in 
the CVS repository. The required changes are :
- in the "import-log4j-jar" target, upgrade the log4j version to 
"log4j-1.2.7.jar",
- in the "compile" target, add an exclude to the "javac" task :
      <exclude name="org/apache/log/output/lf5/**"
               unless="log4j.present"/>

The use of this GUI requires to have log4j (or its org.apache.log4j.lf5 
subpackage) in the classpath.

Hope you'll find this useful,
Sylvain

-- 
Sylvain Wallez                                  Anyware Technologies
http://www.apache.org/~sylvain           http://www.anyware-tech.com
{ XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }


Re: logkit addition ? (was Re: [logkit][patch] A Swing GUI for logkit)

Posted by Peter Donald <pe...@realityforge.org>.
add em in.

On Thu, 23 Jan 2003 00:20, Marcus Crafter wrote:
> Hi All,
>
> 	Hope all is well.
>
> 	Does anyone see any problems if I go ahead and commit this patch
> 	from Sylvain - I saw some posts about releasing logkit earlier in
> 	the month so I'm just wondering if we should put this is into logkit
> 	now or after the release goes through ?
>
> 	Cheers,
>
> 	Marcus
>
> On Mon, Jan 20, 2003 at 02:51:45PM +0100, Sylvain Wallez wrote:
> > Marcus Crafter wrote:
> > >Awesome work Sylvain! Looks great! :)
> >
> > Looks great, but "awesome" it too much for 3 small classes !
> > Would you mind committing this ?
> >
> > Thanks,
> > Sylvain
> >
> > --
> > Sylvain Wallez                                  Anyware Technologies
> > http://www.apache.org/~sylvain           http://www.anyware-tech.com
> > { XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }
> >
> >
> >
> > --
> > To unsubscribe, e-mail:  
> > <ma...@jakarta.apache.org> For additional
> > commands, e-mail: <ma...@jakarta.apache.org>

-- 
Cheers,

Peter Donald
---------------------------------------------------------
Clarke's Third Law: "Any technology distinguishable from 
magic is insufficiently advanced".
---------------------------------------------------------


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: logkit addition ? (was Re: [logkit][patch] A Swing GUI for logkit)

Posted by Peter Donald <pe...@realityforge.org>.
On Thu, 23 Jan 2003 00:28, Stephen McConnell wrote:
> I keen to see this inside logkit - but I think it should be packaged as
> a seperate jar (even if it is three small classes).  Reason being that I
> prefer to keep logkit as small as possible.

I think a separate jar for three classes is being a bit silly. 

-- 
Cheers,

Peter Donald
*----------------------------------------------------------*
The phrase "computer literate user" really means the person 
has been hurt so many times that the scar tissue is thick 
enough so he no longer feels the pain. 
   -- Alan Cooper, The Inmates are Running the Asylum 
*----------------------------------------------------------*


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: logkit addition ? (was Re: [logkit][patch] A Swing GUI for logkit)

Posted by Sylvain Wallez <sy...@anyware-tech.com>.
Marcus Crafter wrote:

>On Thu, Jan 23, 2003 at 10:27:49AM +0100, Sylvain Wallez wrote:
>  
>
>>Marcus, the LF5TargetFactory should go into excalibur.logger.*factory*.
>>    
>>
>	
>	Ah, fixed, thanks for picking that up!
>

Looks fine now. Thanks, mate !

Sylvain

-- 
Sylvain Wallez                                  Anyware Technologies
http://www.apache.org/~sylvain           http://www.anyware-tech.com
{ XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: logkit addition ? (was Re: [logkit][patch] A Swing GUI for logkit)

Posted by Marcus Crafter <cr...@fztig938.bank.dresdner.net>.
On Thu, Jan 23, 2003 at 10:27:49AM +0100, Sylvain Wallez wrote:
> 
> Marcus, the LF5TargetFactory should go into excalibur.logger.*factory*.
	
	Ah, fixed, thanks for picking that up!
	
	Cheers,
	
	Marcus

-- 
        .....
     ,,$$$$$$$$$,      Marcus Crafter
    ;$'      '$$$$:    Computer Systems Engineer
    $:         $$$$:   ManageSoft GmbH
     $       o_)$$$:   82-84 Mainzer Landstrasse
     ;$,    _/\ &&:'   60327 Frankfurt Germany
       '     /( &&&
           \_&&&&'
          &&&&.
    &&&&&&&:

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: logkit addition ? (was Re: [logkit][patch] A Swing GUI for logkit)

Posted by Sylvain Wallez <sy...@anyware-tech.com>.
Marcus Crafter wrote:

>On Wed, Jan 22, 2003 at 06:05:04PM +0100, Leo Simons wrote:
>  
>
>>just thoughts, go ahead and commit if it makes sense!
>>    
>>
>
>	Ok, applied both logkit and excalibur patches.
>	
>	Sylvain, can you please cross check and let me know if everything
>	is ok. Thanks again mate for your work! :)	
>

Marcus, the LF5TargetFactory should go into excalibur.logger.*factory*.

Thanks,
Sylvain

-- 
Sylvain Wallez                                  Anyware Technologies
http://www.apache.org/~sylvain           http://www.anyware-tech.com
{ XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: logkit addition ? (was Re: [logkit][patch] A Swing GUI for logkit)

Posted by Marcus Crafter <cr...@fztig938.bank.dresdner.net>.
On Wed, Jan 22, 2003 at 06:05:04PM +0100, Leo Simons wrote:
> just thoughts, go ahead and commit if it makes sense!

	Ok, applied both logkit and excalibur patches.
	
	Sylvain, can you please cross check and let me know if everything
	is ok. Thanks again mate for your work! :)
	
	Cheers,
	
	Marcus

-- 
        .....
     ,,$$$$$$$$$,      Marcus Crafter
    ;$'      '$$$$:    Computer Systems Engineer
    $:         $$$$:   ManageSoft GmbH
     $       o_)$$$:   82-84 Mainzer Landstrasse
     ;$,    _/\ &&:'   60327 Frankfurt Germany
       '     /( &&&
           \_&&&&'
          &&&&.
    &&&&&&&:

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: logkit addition ? (was Re: [logkit][patch] A Swing GUI for logkit)

Posted by Sylvain Wallez <sy...@anyware-tech.com>.
Leo Simons wrote:

> - I like the tool and want it in!


Me too ;-)

> - is the library it links to open source, or free, or at least free to 
> link to?


Ok. Maybe I wasn't clear in the first post : this LogFactor5 (LF5 for 
short) *was* a commercial product that was donated to the Log4J project 
last year (see [1]). So it's now hosted and maintained by Apache.

This is a logging GUI that is logging system-agnostic. Just an adapter 
to write from LogKit's LogEvent to LF5's LogRecord and we're done.

The library it's linked to is log4j.jar, or only its 
"org.apache.log4j.lf5" package if we don't want to distribute the full 
competitor's jar with logkit ;-)

> - the inclusion should be optional like is done for the existing log 
> targets; haven't checked whether the patch includes that functionality


There was already a test for the presence of Log4J in logkit's build 
(don't know why), I just had to update the version number to the latest 
release, which contains LF5.

> - it doesn't break anything existing code I believe, and if the code 
> has been amply tested, I'm happy with throwing it in right now


It shouldn't break anything, since if you don't use it, it's never loaded.

> - my 2pc would be to add this stuff to logkit itself; it's not utility 
> code but a LogTarget 


That were my thoughts also. Having it inside LogKit is also IMO a great 
marketing benefit, since LogKit claims to be the simplest and the 
fastest (and it is), but lacks some nifty convenience tools that "other" 
log systems provide.

Sylvain

[1] http://marc.theaimsgroup.com/?l=log4j-dev&m=101848239816243&w=2

-- 
Sylvain Wallez                                  Anyware Technologies
http://www.apache.org/~sylvain           http://www.anyware-tech.com
{ XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: logkit addition ? (was Re: [logkit][patch] A Swing GUI for logkit)

Posted by Leo Simons <le...@apache.org>.
- I like the tool and want it in!
- is the library it links to open source, or free, or at least free to 
link to?
- the inclusion should be optional like is done for the existing log 
targets; haven't checked whether the patch includes that functionality
- it doesn't break anything existing code I believe, and if the code has 
been amply tested, I'm happy with throwing it in right now

- my 2pc would be to add this stuff to logkit itself; it's not utility 
code but a LogTarget

just thoughts, go ahead and commit if it makes sense!

cheers,

- Leo



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: logkit addition ? (was Re: [logkit][patch] A Swing GUI for logkit)

Posted by Marcus Crafter <cr...@fztig938.bank.dresdner.net>.
Hi Stephen,

	Hope things are going well mate! :)
	
On Wed, Jan 22, 2003 at 03:27:05PM +0100, Stephen McConnell wrote:
>
> Not really - its not big thing. I havn't looked at the sources in 
> question - just working on the principal of seperating the core logkit 
> package from a tool related to the package.  Why? Because I'm interested 
> in the subject and would dig into this some more at some point in the 
> future.

	From what I can see the classes Sylvain wrote act only as the bridge,
	the actual LogFactor5 tool itself is located in the log4j jar 
	separately.
	
	I think the code would be ok where Sylvain has it though - there's 
	already other non-core related output targets there. What do you
	reckon ? Still think it would be a problem ?
	
	Just my 2c AUS :)
	
	Cheers,
	
	Marcus
	
-- 
        .....
     ,,$$$$$$$$$,      Marcus Crafter
    ;$'      '$$$$:    Computer Systems Engineer
    $:         $$$$:   ManageSoft GmbH
     $       o_)$$$:   82-84 Mainzer Landstrasse
     ;$,    _/\ &&:'   60327 Frankfurt Germany
       '     /( &&&
           \_&&&&'
          &&&&.
    &&&&&&&:

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: logkit addition ? (was Re: [logkit][patch] A Swing GUI for logkit)

Posted by Sylvain Wallez <sy...@anyware-tech.com>.
Stephen McConnell wrote:

>
>
> Sylvain Wallez wrote:
>
>> Stephen McConnell wrote:
>>
>>>
>>>
>>> Marcus Crafter wrote:
>>>
>>>> Hi All,
>>>>
>>>>     Hope all is well.
>>>>         Does anyone see any problems if I go ahead and commit this 
>>>> patch
>>>>     from Sylvain - I saw some posts about releasing logkit earlier in
>>>>     the month so I'm just wondering if we should put this is into 
>>>> logkit
>>>>     now or after the release goes through ?
>>>
>>>
>>>
>>>
>>> Hi Markus:
>>>
>>> I keen to see this inside logkit - but I think it should be packaged 
>>> as a seperate jar (even if it is three small classes).  Reason being 
>>> that I prefer to keep logkit as small as possible.
>>
>>
>>
>>
>> There's already some Servlet, JDBC and JMS stuff in logkit. Does 
>> these _two_ classes (the third one is in excalibur-logger) hurt ?
>
>
>
> Not really - its not big thing. I havn't looked at the sources in 
> question - just working on the principal of seperating the core logkit 
> package from a tool related to the package.  Why? Because I'm 
> interested in the subject and would dig into this some more at some 
> point in the future. 
>
>>
>> If yes, then where should they be located ? In excalibur-logger ? But 
>> there are currently only TargetFactories here...
>
>
> I'm happy to go with whatever you think is best.


So let's put all this in excalibur.logger.factory. This package was 
created to avoid dependencies of LogKit on the framework, so this seems 
to be a good place.

Should I resubmit an updated patch ?

Sylvain

-- 
Sylvain Wallez                                  Anyware Technologies
http://www.apache.org/~sylvain           http://www.anyware-tech.com
{ XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: logkit addition ? (was Re: [logkit][patch] A Swing GUI for logkit)

Posted by Stephen McConnell <mc...@apache.org>.

Sylvain Wallez wrote:

> Stephen McConnell wrote:
>
>>
>>
>> Marcus Crafter wrote:
>>
>>> Hi All,
>>>
>>>     Hope all is well.
>>>         Does anyone see any problems if I go ahead and commit this 
>>> patch
>>>     from Sylvain - I saw some posts about releasing logkit earlier in
>>>     the month so I'm just wondering if we should put this is into 
>>> logkit
>>>     now or after the release goes through ?
>>
>>
>>
>> Hi Markus:
>>
>> I keen to see this inside logkit - but I think it should be packaged 
>> as a seperate jar (even if it is three small classes).  Reason being 
>> that I prefer to keep logkit as small as possible.
>
>
>
> There's already some Servlet, JDBC and JMS stuff in logkit. Does these 
> _two_ classes (the third one is in excalibur-logger) hurt ?


Not really - its not big thing. I havn't looked at the sources in 
question - just working on the principal of seperating the core logkit 
package from a tool related to the package.  Why? Because I'm interested 
in the subject and would dig into this some more at some point in the 
future.  

>
> If yes, then where should they be located ? In excalibur-logger ? But 
> there are currently only TargetFactories here...


I'm happy to go with whatever you think is best.

Cheers, Steve.

>
> Sylvain
>

-- 

Stephen J. McConnell
mailto:mcconnell@apache.org
http://www.osm.net




--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: logkit addition ? (was Re: [logkit][patch] A Swing GUI for logkit)

Posted by Sylvain Wallez <sy...@anyware-tech.com>.
Stephen McConnell wrote:

>
>
> Marcus Crafter wrote:
>
>> Hi All,
>>
>>     Hope all is well.
>>     
>>     Does anyone see any problems if I go ahead and commit this patch
>>     from Sylvain - I saw some posts about releasing logkit earlier in
>>     the month so I'm just wondering if we should put this is into logkit
>>     now or after the release goes through ?
>
>
> Hi Markus:
>
> I keen to see this inside logkit - but I think it should be packaged 
> as a seperate jar (even if it is three small classes).  Reason being 
> that I prefer to keep logkit as small as possible.


There's already some Servlet, JDBC and JMS stuff in logkit. Does these 
_two_ classes (the third one is in excalibur-logger) hurt ?

If yes, then where should they be located ? In excalibur-logger ? But 
there are currently only TargetFactories here...

Sylvain

-- 
Sylvain Wallez                                  Anyware Technologies
http://www.apache.org/~sylvain           http://www.anyware-tech.com
{ XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: logkit addition ? (was Re: [logkit][patch] A Swing GUI for logkit)

Posted by Stephen McConnell <mc...@apache.org>.

Marcus Crafter wrote:

>Hi All,
>
>	Hope all is well.
>	
>	Does anyone see any problems if I go ahead and commit this patch
>	from Sylvain - I saw some posts about releasing logkit earlier in
>	the month so I'm just wondering if we should put this is into logkit
>	now or after the release goes through ?
>	
>

Hi Markus:

I keen to see this inside logkit - but I think it should be packaged as 
a seperate jar (even if it is three small classes).  Reason being that I 
prefer to keep logkit as small as possible.

Cheers, Steve.

-- 

Stephen J. McConnell
mailto:mcconnell@apache.org
http://www.osm.net




--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


logkit addition ? (was Re: [logkit][patch] A Swing GUI for logkit)

Posted by Marcus Crafter <cr...@fztig938.bank.dresdner.net>.
Hi All,

	Hope all is well.
	
	Does anyone see any problems if I go ahead and commit this patch
	from Sylvain - I saw some posts about releasing logkit earlier in
	the month so I'm just wondering if we should put this is into logkit
	now or after the release goes through ?
	
	Cheers,
	
	Marcus
	
On Mon, Jan 20, 2003 at 02:51:45PM +0100, Sylvain Wallez wrote:
> Marcus Crafter wrote:
> 
> >Awesome work Sylvain! Looks great! :)
> > 
> >
> 
> Looks great, but "awesome" it too much for 3 small classes !
> Would you mind committing this ?
> 
> Thanks,
> Sylvain
> 
> -- 
> Sylvain Wallez                                  Anyware Technologies
> http://www.apache.org/~sylvain           http://www.anyware-tech.com
> { XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }
> 
> 
> 
> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
> 

-- 
        .....
     ,,$$$$$$$$$,      Marcus Crafter
    ;$'      '$$$$:    Computer Systems Engineer
    $:         $$$$:   ManageSoft GmbH
     $       o_)$$$:   82-84 Mainzer Landstrasse
     ;$,    _/\ &&:'   60327 Frankfurt Germany
       '     /( &&&
           \_&&&&'
          &&&&.
    &&&&&&&:

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [logkit][patch] A Swing GUI for logkit

Posted by Sylvain Wallez <sy...@anyware-tech.com>.
Marcus Crafter wrote:

>Awesome work Sylvain! Looks great! :)
>  
>

Looks great, but "awesome" it too much for 3 small classes !
Would you mind committing this ?

Thanks,
Sylvain

-- 
Sylvain Wallez                                  Anyware Technologies
http://www.apache.org/~sylvain           http://www.anyware-tech.com
{ XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [logkit][patch] A Swing GUI for logkit

Posted by Marcus Crafter <cr...@fztig938.bank.dresdner.net>.
Awesome work Sylvain! Looks great! :)

Cheers,

Marcus

On Sat, Jan 18, 2003 at 11:47:29PM +0100, Sylvain Wallez wrote:
> Hi,
> 
> A few months ago, LogFactor5, a commercial Swing GUI for log4j was 
> donated to the log4j project. But this GUI is actually logging-system 
> agnostic, so I wrote a brigde for logkit.
> 
> You can see it in action with Cocoon at 
> http://cvs.apache.org/~sylvain/lf5/lf5-logkit.gif
> 
> Please find attached :
> - lf5-logkit.zip : content of the new org.apache.log.output.lf5 package 
> for logkit,
> - LF5TargetFactory.java : new target factory for excalibur-logger.
> 
> Logkit's build also requires some changes, but I wasn't able to diff it 
> because there seems to be some line ending problems on what's stored in 
> the CVS repository. The required changes are :
> - in the "import-log4j-jar" target, upgrade the log4j version to 
> "log4j-1.2.7.jar",
> - in the "compile" target, add an exclude to the "javac" task :
>      <exclude name="org/apache/log/output/lf5/**"
>               unless="log4j.present"/>
> 
> The use of this GUI requires to have log4j (or its org.apache.log4j.lf5 
> subpackage) in the classpath.
> 
> Hope you'll find this useful,
> Sylvain
> 
> -- 
> Sylvain Wallez                                  Anyware Technologies
> http://www.apache.org/~sylvain           http://www.anyware-tech.com
> { XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }


-- 
        .....
     ,,$$$$$$$$$,      Marcus Crafter
    ;$'      '$$$$:    Computer Systems Engineer
    $:         $$$$:   ManageSoft GmbH
     $       o_)$$$:   82-84 Mainzer Landstrasse
     ;$,    _/\ &&:'   60327 Frankfurt Germany
       '     /( &&&
           \_&&&&'
          &&&&.
    &&&&&&&:

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [logkit][patch] A Swing GUI for logkit

Posted by Peter Donald <pe...@realityforge.org>.
excellent!

On Sun, 19 Jan 2003 09:47, Sylvain Wallez wrote:
> Hi,
>
> A few months ago, LogFactor5, a commercial Swing GUI for log4j was
> donated to the log4j project. But this GUI is actually logging-system
> agnostic, so I wrote a brigde for logkit.
>
> You can see it in action with Cocoon at
> http://cvs.apache.org/~sylvain/lf5/lf5-logkit.gif
>
> Please find attached :
> - lf5-logkit.zip : content of the new org.apache.log.output.lf5 package
> for logkit,
> - LF5TargetFactory.java : new target factory for excalibur-logger.
>
> Logkit's build also requires some changes, but I wasn't able to diff it
> because there seems to be some line ending problems on what's stored in
> the CVS repository. The required changes are :
> - in the "import-log4j-jar" target, upgrade the log4j version to
> "log4j-1.2.7.jar",
> - in the "compile" target, add an exclude to the "javac" task :
>       <exclude name="org/apache/log/output/lf5/**"
>                unless="log4j.present"/>
>
> The use of this GUI requires to have log4j (or its org.apache.log4j.lf5
> subpackage) in the classpath.
>
> Hope you'll find this useful,
> Sylvain

-- 
Cheers,

Peter Donald
*------------------------------------------------------*
| "The whole problem with the world is that fools and  |
| fanatics are always so certain of themselves, but    |
| wiser people so full of doubts." - Bertrand Russell  |
*------------------------------------------------------*



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>