You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/21 19:41:01 UTC
[GitHub] [kafka] bbejeck opened a new pull request #9774: MINOR: Add 2.7.0 release to broker and client compat tests
bbejeck opened a new pull request #9774:
URL: https://github.com/apache/kafka/pull/9774
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck edited a comment on pull request #9774: MINOR: Add 2.7.0 release to broker and client compat tests
Posted by GitBox <gi...@apache.org>.
bbejeck edited a comment on pull request #9774:
URL: https://github.com/apache/kafka/pull/9774#issuecomment-749164456
System test build https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4323/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck merged pull request #9774: MINOR: Add 2.7.0 release to broker and client compat tests
Posted by GitBox <gi...@apache.org>.
bbejeck merged pull request #9774:
URL: https://github.com/apache/kafka/pull/9774
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #9774: MINOR: Add 2.7.0 release to broker and client compat tests
Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #9774:
URL: https://github.com/apache/kafka/pull/9774#issuecomment-754676928
[latest round of system tests passed](http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2021-01-04--001.1609804130--bbejeck--MINOR_add_2_7_to_broker_and_client_compat_tests--52e55121f/report.html)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #9774: MINOR: Add 2.7.0 release to broker and client compat tests
Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #9774:
URL: https://github.com/apache/kafka/pull/9774#issuecomment-750411633
System tests passed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck edited a comment on pull request #9774: MINOR: Add 2.7.0 release to broker and client compat tests
Posted by GitBox <gi...@apache.org>.
bbejeck edited a comment on pull request #9774:
URL: https://github.com/apache/kafka/pull/9774#issuecomment-749164456
System test build https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4327/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck edited a comment on pull request #9774: MINOR: Add 2.7.0 release to broker and client compat tests
Posted by GitBox <gi...@apache.org>.
bbejeck edited a comment on pull request #9774:
URL: https://github.com/apache/kafka/pull/9774#issuecomment-754240203
@ijuma, I've updated and kicked off [a new round of system tests](https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4335/).
When the system tests pass, I'll merge the PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #9774: MINOR: Add 2.7.0 release to broker and client compat tests
Posted by GitBox <gi...@apache.org>.
ijuma commented on a change in pull request #9774:
URL: https://github.com/apache/kafka/pull/9774#discussion_r551392400
##########
File path: tests/kafkatest/tests/core/upgrade_test.py
##########
@@ -76,10 +76,14 @@ def perform_upgrade(self, from_kafka_version, to_message_format_version=None):
self.wait_until_rejoin()
@cluster(num_nodes=6)
- @parametrize(from_kafka_version=str(LATEST_2_4), to_message_format_version=None, compression_types=["none"])
- @parametrize(from_kafka_version=str(LATEST_2_4), to_message_format_version=None, compression_types=["zstd"])
+ @parametrize(from_kafka_version=str(LATEST_2_7), to_message_format_version=None, compression_types=["none"])
+ @parametrize(from_kafka_version=str(LATEST_2_7), to_message_format_version=None, compression_types=["zstd"])
+ @parametrize(from_kafka_version=str(LATEST_2_6), to_message_format_version=None, compression_types=["none"])
+ @parametrize(from_kafka_version=str(LATEST_2_6), to_message_format_version=None, compression_types=["zstd"])
Review comment:
Instead of using zstd for the new versions, we could rotate over the compression algorithms. Maybe `lz4` and `snappy`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #9774: MINOR: Add 2.7.0 release to broker and client compat tests
Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #9774:
URL: https://github.com/apache/kafka/pull/9774#issuecomment-754009374
ping @ijuma for review. It would be good to have a pair of eyes from core to review this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #9774: MINOR: Add 2.7.0 release to broker and client compat tests
Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #9774:
URL: https://github.com/apache/kafka/pull/9774#issuecomment-754240203
@ijuma, I've updated and kicked off a new round of system tests.
When the system tests pass, I'll merge the PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #9774: MINOR: Add 2.7.0 release to broker and client compat tests
Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #9774:
URL: https://github.com/apache/kafka/pull/9774#issuecomment-749164456
System test build https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4322/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck edited a comment on pull request #9774: MINOR: Add 2.7.0 release to broker and client compat tests
Posted by GitBox <gi...@apache.org>.
bbejeck edited a comment on pull request #9774:
URL: https://github.com/apache/kafka/pull/9774#issuecomment-749164456
System test build https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4325/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #9774: MINOR: Add 2.7.0 release to broker and client compat tests
Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #9774:
URL: https://github.com/apache/kafka/pull/9774#issuecomment-754678890
Merged #9774 into trunk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org