You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by "QuanticPony (via GitHub)" <gi...@apache.org> on 2023/04/14 14:51:48 UTC
[I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout (plc4x)
QuanticPony opened a new issue, #900:
URL: https://github.com/apache/plc4x/issues/900
### What happened?
## Summary
When a connection stored in the connection-cache breaks due to a network failure, the connection is not removed from the cache and blocks future uses of the same connection string.
## Context
Encountered while trying to solve a similar problem as https://github.com/apache/plc4x/issues/623 in the NiFi integration:
When a processor is running and the network connection to the PLC is interrupted, the processors continues to throw errors even if the network connection is restored.
This was brought up in a mail by me (https://lists.apache.org/thread/xm38nh8xzh1m1kj0y74dx0goo81cos82) that sparked a pull request by [heyoulin](https://github.com/spnettec) (https://github.com/apache/plc4x/pull/818), an issue by [splatch](https://github.com/splatch) (https://github.com/apache/plc4x/issues/821) and a commit from [@chrisdutz ](https://github.com/chrisdutz) (https://github.com/apache/plc4x/commit/9b06c2de0c77a7c1bbcb730bb5285c4435002c93).
The commit (https://github.com/apache/plc4x/commit/9b06c2de0c77a7c1bbcb730bb5285c4435002c93) did not fully addressed the problem, so I bring my attempt to fix it.
## Replicate the problem
In order to replicate the problem use the code at the end and follow the steps:
1) Start the main below
2) Disconnect network
3) Wait until errors are shown in the stdout
4) You will see the connection is been used after it fails:
```
16:38:22.486 [main] DEBUG o.a.p.j.u.c.CachedPlcConnectionManager.getConnection:72 - Reusing exising connection
Failed to read due to:
java.util.concurrent.TimeoutExceptio
```
5) Reconnect network. The problem persists.
## Possible Solution
The LeasedConnection returns a Future that encapsulates the Future that connects to the PLC. The second one is the one that can mark the connection as invalid for removal. For the moment I have been able to work around this by overriding the `get` method of the first Future:
```java
@Override
public PlcReadResponse get(long timeout, TimeUnit unit)
throws InterruptedException, ExecutionException, TimeoutException {
try {
return super.get(timeout, unit);
} catch (TimeoutException e) {
future.completeExceptionally(e);
throw e;
}
}
```
You can see my solution in the zylklab fork (https://github.com/zylklab/plc4x/tree/Fix/nifi-integration-timeout). If you could give me some feedback I would like to make this into a PR as soon as posible.
_____
```java
public class ManualTest {
public static void main(String[] args) throws InterruptedException {
CachedPlcConnectionManager cachedPlcConnectionManager = CachedPlcConnectionManager.getBuilder(new DefaultPlcDriverManager()).withMaxLeaseTime(Duration.ofMinutes(5)).build();
for (int i = 0; i < 100; i++){
Thread.sleep(1000);
try (PlcConnection connection = cachedPlcConnectionManager.getConnection("s7://10.105.143.7:102?remote-rack=0&remote-slot=1&controller-type=S7_1200")) {
PlcReadRequest.Builder plcReadRequestBuilder = connection.readRequestBuilder();
plcReadRequestBuilder.addTagAddress("foo", "%DB1:DBX0.0:BOOL");
PlcReadRequest plcReadRequest = plcReadRequestBuilder.build();
PlcReadResponse plcReadResponse = plcReadRequest.execute().get(1000, TimeUnit.MILLISECONDS);
System.out.printf("Run %d: Value: %f%n", i, plcReadResponse.getFloat("foo"));
} catch (Exception e) {
System.out.println("Failed to read due to: ");
e.printStackTrace();
}
}
}
}
```
### Version
v0.11.0-SNAPSHOT
### Programming Languages
- [X] plc4j
- [ ] plc4go
- [ ] plc4c
- [ ] plc4net
### Protocols
- [ ] AB-Ethernet
- [ ] ADS /AMS
- [ ] BACnet/IP
- [ ] CANopen
- [ ] DeltaV
- [ ] DF1
- [ ] EtherNet/IP
- [ ] Firmata
- [ ] KNXnet/IP
- [ ] Modbus
- [ ] OPC-UA
- [ ] S7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout (plc4x)
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1653121824
Think I found it ... so the NettyHashTimerTimeoutManager.java in line 54 creates a Timeout exception ... this is not a PlcException or PlcRuntimeException, so it falls outside all catch blocks ... I think changing this to a PlcTimeoutException that extends PlcRuntimeException should also fix many of these issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout
Posted by "QuanticPony (via GitHub)" <gi...@apache.org>.
QuanticPony commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1731367783
Acknowledgement that I will test this next week
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout (plc4x)
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1653091384
Ok ... so the first test passes in my setup ... however the second one I'm not really sure how it should fail ... the timeout is on the request execution ... so the client says "give me that in 50 ms" this timeout is only in the CompletableFuture and the driver has no way to know how long the client is willing to wait.
I guess I should think of a way, that the operation times out internally (without waiting 10 seconds or so)
Or how does the driver know about your completable future timeout?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout (plc4x)
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1618758885
Interrestingly it did recover after quite some time ... will look into this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1731299659
Could you folks prease try this again and give me feedback, if this issue is now fixed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout (plc4x)
Posted by "QuanticPony (via GitHub)" <gi...@apache.org>.
QuanticPony commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1652087124
@chrisdutz I have made a unit test for the behavior that I think is correct. You can check it [here](https://github.com/zylklab/plc4x/blob/timeout-fix/plc4j/tools/connection-cache/src/test/java/org/apache/plc4x/java/utils/cache/LeasedPlcConnectionTest.java)
The problem that I see is that any exception while (for example) reading from the plc triggers the LeasedPlcConnection to be invalidated. But a timeout due to a broken connection does not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout
Posted by "QuanticPony (via GitHub)" <gi...@apache.org>.
QuanticPony commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1740578111
@chrisdutz Implemented already in our fork. Working pretty well. Will be posting a PR soon with the changes needed for the NiFi integration to work properly again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout
Posted by "QuanticPony (via GitHub)" <gi...@apache.org>.
QuanticPony closed issue #900: [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout
URL: https://github.com/apache/plc4x/issues/900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1733801063
I just added two methods that allow manual removal of connections from the cache ... not tested at all ... feel free to try it out. There are now two methods:
- getCachedConnections which returns a set of connection urls
- removeCachedConnection(String) removes a conection with the given url from the cache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout (plc4x)
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1651717338
I think my main problem is, how can I simulate the situation in a unit-test to prove the cache works correctly.
Could you please describe the situation exactly and what you're seeing the system do? I'd try to replicate this, however I couldn't replicate the driver not coming back to life.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout (plc4x)
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1618779776
So I guess the problem is, that we have a connection timeout that is longer than your 1 second timeout ... so it looks as if the connection fails and the next connect runs into the void ... we then wait for this to timeout and then create a new attempt ... if the connection is available again, it connects then and the application recovers or if it's not available, we wait for the next connection timeout and then try again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout (plc4x)
Posted by "spnettec (via GitHub)" <gi...@apache.org>.
spnettec commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1617414156
Can you try my repository? If work. I can push the plcconnection bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout (plc4x)
Posted by "spnettec (via GitHub)" <gi...@apache.org>.
spnettec commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1618977430
It is not connection-cache bug. It is base Plc4xNettyWrapper bug exsit long long time. I fixed in #818. But you did not accept my fix. You can check #801. It is partly resove this hug bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1731338954
So ... is this fixed or was the thumb up just an acknowledgement that you'll be doing that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout (plc4x)
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1618863883
Ok ... keeping the connection separated longer than the connection timeout resulted in a different set of errors. Unfortunately I didn't quite understand your solution or couldn't find it in the branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout (plc4x)
Posted by "QuanticPony (via GitHub)" <gi...@apache.org>.
QuanticPony commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1651450629
Hi again. I had a look into the nifi integration after updating the branch:
Found the S7 driver reconnecting, but the opcua didn't.
Tried the manual tests that posted in this issue with both drivers. Same result.
Additionally found that the s7 driver always reconnected after 15 disconnect messages.
From this I take that it depends on how the driver interprets when there is a disconnection.
Not sure how should we handle the reconnection from the nifi integration part. Right now using it to connect to an opcua plc means after a disconnection a user must restart manually the processors or restart nifi.
Tried again with the changes I made. It reconnects in both cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout (plc4x)
Posted by "QuanticPony (via GitHub)" <gi...@apache.org>.
QuanticPony commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1653113922
The connection cache gives a leased connection with the real connection inside. If an exception occurs in the real connection the leased connection is invalidated. This is the first test.
I think is a problem that if the client gets a timeout in the leased connection the CompletableFuture of the real connection, the one that invalidates the leased connection, does not. This is the case that breaks the cache in my case, as that connection is no longer usable. I think a timeout in the leased connection should propagate into the real connection. Making the real connection invalid. Else the client has no way of removing the real connection from the connection cache.
This one is the second test.
I see 2 solutions. Either propagate the timeout or allow the client to manually invalidate a connection from the cache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout (plc4x)
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1645800060
Ok ... so if I have a look at the changes it seems your branch is quite diverged from develop ... I'd like to help work on fixing any issues you might be having here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout (plc4x)
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1618757839
Sorry for the late response. I was able to reproduce the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1740598025
well ... we're planning on cutting the RC for 0.10.0 on monday ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout (plc4x)
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1653116776
Well I did locally change the LeasedConnection to simply react on Exception instead of PlcRuntimeException ... this should now catch timeout errors too ... but I'm looking, if we shouldn't be catcing the timeouts and converting them to Plc-exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout (plc4x)
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1653039718
Thanks for that ... of course do I first have to finish my changes on the subscription API first, or nothing will compile ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout (plc4x)
Posted by "sruehl (via GitHub)" <gi...@apache.org>.
sruehl commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1618286751
@chrisdutz can you look into this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout (plc4x)
Posted by "QuanticPony (via GitHub)" <gi...@apache.org>.
QuanticPony commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1619721349
@spnettec I tried your branch a long time ago and seemed to work. I only used your changes to the connection-cache in that testing.
@chrisdutz When I created this issue I didn't get a single re-connection. I have pulled from develop and I also get re-connections. Will try the nifi integration that was not working. Will let you know if it works properly!
> Ok ... keeping the connection separated longer than the connection timeout resulted in a different set of errors. Unfortunately I didn't quite understand your solution or couldn't find it in the branch.
If you are looking for my changes you can view them [here](https://github.com/zylklab/plc4x/commits/Fix/nifi-integration-timeout/plc4j/tools/connection-cache/src/main/java/org/apache/plc4x/java/utils/cache/LeasedPlcConnection.java).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout (plc4x)
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1620087777
@spnettec I think I didn't accept your PR as I think it addressed multiple things and changed the API of PLC4X in an undesirable way. That was why I tried implementing an alternate path.
@QuanticPony thanks for the pointer ... that link helps a lot. Will have a look at it after work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout
Posted by "QuanticPony (via GitHub)" <gi...@apache.org>.
QuanticPony commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1733756482
@chrisdutz I have tested it in the NiFi integration with a S7 and an OPC UA. Same as last time:
The S7 driver detected the invalid connection and successfully reconnected. The OPC UA driver did not.
I am pretty sure this is a driver related problem right now.
Nevertheless I would suggest adding a way of removing LeasedPlcConnections from the cache manually.
I will close this issue. Thank you for your help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org