[GitHub] john-bodley opened a new pull request #3583: [3541] Augmenting datasources uniqueness constraints

[gi...@git.apache.org]

john-bodley opened a new pull request #3583: [3541] Augmenting datasources uniqueness constraints
URL: https://github.com/apache/incubator-superset/pull/3583
 
 
   This PR fixes issue #3541 by replacing the uniqueness constraint on the `datasource_name` column of the `datasources` table with the a combination of the `cluster_name` and `datasource_name` columns. 
   
   Note in SQLite constraints can be unnamed, so prior to the migration the table schema is of the form, 
   ```
   sqlite> .schema datasources
   CREATE TABLE "datasources" (
   	...
   	UNIQUE (datasource_name)
   ```
   whereas after running, 
   ```
   superset db upgrade
   superset db downgrade
   ```
   the  equivalent table schema is of the form, 
   ```
   CREATE TABLE "datasources" (
   	...
   	CONSTRAINT uq_datasources_datasource_name UNIQUE (datasource_name), 
   ```
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services