You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/27 13:16:49 UTC

[GitHub] [airflow] mik-laj commented on pull request #7230: [AIRFLOW-6602]: render executor_config before triggering tasks to su…

mik-laj commented on pull request #7230:
URL: https://github.com/apache/airflow/pull/7230#issuecomment-717235786


   @neverset123 There was no reviewer who was mobilized to push these changes forward, and the author did not do it hard enough. The maintainers of this project have very little time to deal with each change and are counting on the authors of the changes to be mobilized and will ask for reviews if the change is ready for review.
   
   > Ping @ #development slack, comment @people. Be annoying. Be considerate.
   
   https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow
   
   I also have doubts if this change works correctly with DAG Serialization and if it does not have too much impact on performance, because this code is executed in the main scheduler loop. If this code didn't modify the main loop, it would be a lot easier to merge this change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org