[GitHub] [incubator-gobblin] shirshanka commented on a change in pull request #2641: [GOBBLIN-777] Remove container request after container allocation

[GitBox <gi...@apache.org>]

shirshanka commented on a change in pull request #2641: [GOBBLIN-777] Remove container request after container allocation
URL: https://github.com/apache/incubator-gobblin/pull/2641#discussion_r285876830
 
 

 ##########
 File path: gobblin-yarn/src/test/java/org/apache/gobblin/yarn/YarnServiceTest.java
 ##########
 @@ -284,6 +292,16 @@ protected ContainerLaunchContext newContainerLaunchContext(Container container,
               Arrays.asList("sleep", "60000"), Collections.emptyMap(), null, Collections.emptyMap());
     }
 
+    /**
+     * Get the list of matching container requests for the specified resource memory and cores.
+     */
+    public List<? extends Collection<AMRMClient.ContainerRequest>> getMatchingRequestsList(int memory, int cores) {
 
 Review comment:
   is this method used somewhere?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services