You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2018/04/24 20:51:07 UTC
[jira] [Commented] (HADOOP-11869) Suppress ParameterNumber
checkstyle violations for overridden methods
[ https://issues.apache.org/jira/browse/HADOOP-11869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16450754#comment-16450754 ]
Hudson commented on HADOOP-11869:
---------------------------------
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14057 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/14057/])
HADOOP-11869. Suppress ParameterNumber checkstyle violations for (xyao: rev 83fef23141d27591c3a1ea5d02b8056cf44e4f56)
* (edit) hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml
> Suppress ParameterNumber checkstyle violations for overridden methods
> ---------------------------------------------------------------------
>
> Key: HADOOP-11869
> URL: https://issues.apache.org/jira/browse/HADOOP-11869
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Sidharta Seethana
> Assignee: Jonathan Eagles
> Priority: Major
> Fix For: 3.0.0-alpha4
>
> Attachments: HADOOP-11869.ParameterNumber.patch
>
>
> There seem to be a lot of arcane errors being caused by the checkstyle rules/script. Real issues tend to be buried in this noise. Some examples :
> 1. "Line is longer than 80 characters" - this shows up even for cases like import statements, package names
> 2. "Missing a Javadoc comment." - for every private member including cases like "Configuration conf".
> Having rules like these will result in a large number of pre-commit job failures. We should fine tune the rules used for checkstyle.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org