You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2023/10/25 14:11:56 UTC
[PR] [fix][test] Fix resource leaks in LoadBalancerTest [pulsar]
lhotari opened a new pull request, #21443:
URL: https://github.com/apache/pulsar/pull/21443
### Motivation
LoadBalancerTest leaks some threads.
### Modifications
- remove the unused thread pool
- while debugging, it revealed that testLeaderElection method caused some thread leaks.
- the logic to prevent duplicate calls to `PulsarService.close()` isn't needed anymore.
- removing this logic fixed the issue although it doesn't seem to be obvious from the code since it looks like cleanup was happening properly also before making these changes.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][test] Fix resource leaks in LoadBalancerTest [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #21443:
URL: https://github.com/apache/pulsar/pull/21443#issuecomment-1780005965
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21443?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#21443](https://app.codecov.io/gh/apache/pulsar/pull/21443?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2d54b77) into [master](https://app.codecov.io/gh/apache/pulsar/commit/04d1225fbb1485333f44138e587aadce34ea1f0e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (04d1225) will **increase** coverage by `0.51%`.
> Report is 3 commits behind head on master.
> The diff coverage is `100.00%`.
[](https://app.codecov.io/gh/apache/pulsar/pull/21443?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #21443 +/- ##
============================================
+ Coverage 72.73% 73.24% +0.51%
- Complexity 32351 32583 +232
============================================
Files 1890 1890
Lines 140331 140333 +2
Branches 15419 15419
============================================
+ Hits 102070 102792 +722
+ Misses 30166 29460 -706
+ Partials 8095 8081 -14
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/21443/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/21443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.24% <37.50%> (?)` | |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/21443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.77% <0.00%> (-0.01%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/21443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.54% <100.00%> (+0.44%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files](https://app.codecov.io/gh/apache/pulsar/pull/21443?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../pulsar/broker/service/AbstractBaseDispatcher.java](https://app.codecov.io/gh/apache/pulsar/pull/21443?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL0Fic3RyYWN0QmFzZURpc3BhdGNoZXIuamF2YQ==) | `94.32% <100.00%> (+1.10%)` | :arrow_up: |
... and [127 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/21443/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][test] Fix resource leaks in LoadBalancerTest [pulsar]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #21443:
URL: https://github.com/apache/pulsar/pull/21443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org