You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/12/12 03:38:02 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #4982: libc/gettextdomain: Fix the typo error
xiaoxiang781216 opened a new pull request #4982:
URL: https://github.com/apache/incubator-nuttx/pull/4982
## Summary
Report here: https://github.com/apache/incubator-nuttx/pull/4978
## Impact
Kernel build
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko edited a comment on pull request #4982: libc/gettextdomain: Fix the typo error
Posted by GitBox <gi...@apache.org>.
pkarashchenko edited a comment on pull request #4982:
URL: https://github.com/apache/incubator-nuttx/pull/4982#issuecomment-991873981
Ok. Probably I will change to `#if !defined(CONFIG_BUILD_KERNEL) && defined(CONFIG_LIBC_LOCALE)` in the next commit. Should be fine for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko edited a comment on pull request #4982: libc/gettextdomain: Fix the typo error
Posted by GitBox <gi...@apache.org>.
pkarashchenko edited a comment on pull request #4982:
URL: https://github.com/apache/incubator-nuttx/pull/4982#issuecomment-991852388
`ta_domain` is under `#ifndef CONFIG_BUILD_KERNEL`, so probably need to change line above as well.
It is also under `# ifdef CONFIG_LIBC_LOCALE`, so it is probably a good way to add same wrapper in this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #4982: libc/gettextdomain: Fix the typo error
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #4982:
URL: https://github.com/apache/incubator-nuttx/pull/4982#issuecomment-991840486
Probably my bad. Now build fails because of unused `g_domain` for kernel build. I will double inspect the current code. Probably I missed something. Let's abandon this change for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4982: libc/gettextdomain: Fix the typo error
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4982:
URL: https://github.com/apache/incubator-nuttx/pull/4982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4982: libc/gettextdomain: Fix the typo error
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4982:
URL: https://github.com/apache/incubator-nuttx/pull/4982#issuecomment-991873108
> `ta_domain` is under `#ifndef CONFIG_BUILD_KERNEL`, so probably need to change line above as well. It is also under `# ifdef CONFIG_LIBC_LOCALE`, so it is probably a good way to add same wrapper in this file
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #4982: libc/gettextdomain: Fix the typo error
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #4982:
URL: https://github.com/apache/incubator-nuttx/pull/4982#issuecomment-991852388
`ta_domain` is under `#ifndef CONFIG_BUILD_KERNEL`, so probably need to change line above as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #4982: libc/gettextdomain: Fix the typo error
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #4982:
URL: https://github.com/apache/incubator-nuttx/pull/4982#issuecomment-991873981
Ok. Probably ai will change to `#if !defined(CONFIG_BUILD_KERNEL) && defined(CONFIG_LIBC_LOCALE)` in the next commit. Should be fine for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org