You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/03/10 12:05:05 UTC

[GitHub] [activemq-artemis] tlbueno edited a comment on pull request #3980: ARTEMIS-3716 move e2e tests to e2e-tests module

tlbueno edited a comment on pull request #3980:
URL: https://github.com/apache/activemq-artemis/pull/3980#issuecomment-1063983122


   > IMO this needs a Jira. At the very least it needs a rebase to pick up [67c9df1](https://github.com/apache/activemq-artemis/commit/67c9df195d4897059de219d677d9a256f5d3a267) which should allow the build checks to finish normally.
   > 
   > Also, please update the commit message to follow the recommendations from the [hacking guide](https://github.com/apache/activemq-artemis/blob/main/docs/hacking-guide/en/maintainers.md#commit-messages).
   > 
   > Thanks!
   
   @jbertram, 
   
   Thank you for the suggestions! 
   I rebased the code, opened a jira, updated the PR title and the commit message title to match the recommendation. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org