[jira] [Commented] (BUILDR-621) ZipTask creates zip file with entries not sorted by path causing very slow unzipping.

["Antoine Toulme (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BUILDR-621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292846#comment-15292846 ] 

Antoine Toulme commented on BUILDR-621:
---------------------------------------

Buildr monkey-patches CentralDirectory to write entries in alphabetical order. See lib/buildr/packaging/zip.rb, line 33.

However, your change is still needed since ZipTask.create_from is using the zip stream directly.

> ZipTask creates zip file with entries not sorted by path causing very slow unzipping.
> -------------------------------------------------------------------------------------
>
>                 Key: BUILDR-621
>                 URL: https://issues.apache.org/jira/browse/BUILDR-621
>             Project: Buildr
>          Issue Type: Bug
>          Components: Packaging
>    Affects Versions: 1.4.7
>            Reporter: Russell Teabeault
>             Fix For: 1.5
>
>
> ZipTask#create_from iterates through the file_map and creates the zip with the entries in no particular order.  With a large zip file this can dramatically slow down unzipping since the physical disk has to do much more random access.  
> Currently the code does:
> file_map.each do |path, content|
> Doing something such as the following would probably be better:
> paths = file_map.keys.sort
> paths.each do |path|
>   content = file_map[path]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)