[GitHub] [incubator-superset] ktmud commented on a change in pull request #10160: feat: Add new timegrains and convert_dttm to Druid engine spec

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #10160:
URL: https://github.com/apache/incubator-superset/pull/10160#discussion_r445373625



##########
File path: superset/db_engine_specs/druid.py
##########
@@ -77,3 +82,12 @@ def get_extra_params(database: "Database") -> Dict[str, Any]:
             engine_params["connect_args"] = connect_args
             extra["engine_params"] = engine_params
         return extra
+
+    @classmethod
+    def convert_dttm(cls, target_type: str, dttm: datetime) -> Optional[str]:

Review comment:
       Make this `Enum`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org