[jira] [Commented] (YETUS-631) Add new command line parameter to define custom mvn argument

["Sean Busbey (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YETUS-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591805#comment-16591805 ] 

Sean Busbey commented on YETUS-631:
-----------------------------------

hit a time this would have been useful in HBase: HBASE-21074

I used our personality's {{personality_modules}} to pass some extra maven args on branches where we expect jdk7 to be used:

{code}
 if [[ "${PATCH_BRANCH}" = branch-1* ]]; then
    extra="${extra} -Dhttps.protocols=TLSv1.2"
  fi
{code}

this worked great for things like {{mvninstall}} or {{unit}}

{code}

============================================================================
============================================================================
                            maven install: full
============================================================================
============================================================================


[Tue Aug 21 19:32:56 UTC 2018 INFO]: Personality: patch mvninstall
cd /testptch/hbase
mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hbase-branch-1.2-full-1 -DHBasePatchProcess -Dhttps.protocols=TLSv1.2 -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /testptch/patchprocess/patch-mvninstall-root.txt 2>&1
Elapsed:   8m 17s
{code}

but the "maven dependency  order" plugin doesn't ask the personality about things so it misses the flag:
{code}
============================================================================
============================================================================
Determining Maven Dependency Order (downloading dependencies in the process)
============================================================================
============================================================================


cd /testptch/hbase
mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hbase-branch-1.2-full-1 -q exec:exec -Dexec.executable=pwd -Dexec.args='' > /testptch/patchprocess/maven-patch-dirlist-root.txt 2>&1
Elapsed:   1m 23s
{code}

It wasn't a blocker because our nightly tests use a docker image with a version of jdk7 that's new enough to not actually need the flag and when I test locally with a jdk7 that does need it yetus gracefully handles the dependency order checker failing.

> Add new command line parameter to define custom mvn argument
> ------------------------------------------------------------
>
>                 Key: YETUS-631
>                 URL: https://issues.apache.org/jira/browse/YETUS-631
>             Project: Yetus
>          Issue Type: Improvement
>          Components: Test Patch
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>         Attachments: YETUS-631.001.patch
>
>
> The HDDS subproject is turned off by default in Hadoop source tree. To make a workable Precommit-HDDS-Build we need a possibility to defined additional mvn arguments from the command line.
> (I tried to use .mvn/maven.config but the current build forces a git clean build. Environment variable could not been used in dockerized environment )



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)