You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/20 09:05:25 UTC
[GitHub] [apisix] cr7258 opened a new pull request, #7092: fix: install dependencies issues
cr7258 opened a new pull request, #7092:
URL: https://github.com/apache/apisix/pull/7092
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
This commit addresses the problem with these issuse:
1. Missing wget on centos and fedora system.
2. luarocks was installed in /usr/local/bin，make sure /usr/local/bin is included in the system default PATH variable.
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
4. Always update the documentation to reflect the changes made in the PR.
5. Make a new commit to resolve conversations instead of `push -f`.
6. To resolve merge conflicts, merge master instead of rebasing.
7. Use "request review" to notify the reviewer after making changes.
8. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a diff in pull request #7092: fix: install dependencies issues
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on code in PR #7092:
URL: https://github.com/apache/apisix/pull/7092#discussion_r878959359
##########
utils/install-dependencies.sh:
##########
@@ -46,7 +46,7 @@ function install_dependencies_with_aur() {
function install_dependencies_with_yum() {
sudo yum install -y yum-utils
- local common_dep="curl git gcc openresty-openssl111-devel unzip pcre pcre-devel openldap-devel"
+ local common_dep="curl wget git gcc openresty-openssl111-devel unzip pcre pcre-devel openldap-devel"
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #7092: fix: install dependencies issues
Posted by GitBox <gi...@apache.org>.
spacewander commented on code in PR #7092:
URL: https://github.com/apache/apisix/pull/7092#discussion_r878850182
##########
utils/linux-install-luarocks.sh:
##########
@@ -53,5 +53,13 @@ if [ -d ${OPENRESTY_PREFIX}/openssl111 ]; then
OPENSSL_PREFIX=${OPENRESTY_PREFIX}/openssl111
fi
+FOUND_PATH=$(echo "${PATH}" | grep -oP '(?<=:|)/usr/local/bin(?=:|)') || true
+if [[ "${FOUND_PATH}" == "" ]]; then
+ echo "the path /usr/local/bin is not included in the system default PATH variable, add PATH variable in ~/.bashrc."
+ echo "export PATH=$PATH:/usr/local/bin" >> ~/.bashrc
Review Comment:
Can we leave bashrc untouched and only update $PATH for this shell? Just warn the user to modify $PATH by themselves as they may not use bash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a diff in pull request #7092: fix: install dependencies issues
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on code in PR #7092:
URL: https://github.com/apache/apisix/pull/7092#discussion_r878644119
##########
utils/install-dependencies.sh:
##########
@@ -46,7 +46,7 @@ function install_dependencies_with_aur() {
function install_dependencies_with_yum() {
sudo yum install -y yum-utils
- local common_dep="curl git gcc openresty-openssl111-devel unzip pcre pcre-devel openldap-devel"
+ local common_dep="curl wget git gcc openresty-openssl111-devel unzip pcre pcre-devel openldap-devel"
Review Comment:
It seems we don't need to modify here?
The `common_dep` here is for the CI runtime environment and only needs to be installed if it is not present in the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] cr7258 commented on a diff in pull request #7092: fix: install dependencies issues
Posted by GitBox <gi...@apache.org>.
cr7258 commented on code in PR #7092:
URL: https://github.com/apache/apisix/pull/7092#discussion_r878665132
##########
utils/install-dependencies.sh:
##########
@@ -46,7 +46,7 @@ function install_dependencies_with_aur() {
function install_dependencies_with_yum() {
sudo yum install -y yum-utils
- local common_dep="curl git gcc openresty-openssl111-devel unzip pcre pcre-devel openldap-devel"
+ local common_dep="curl wget git gcc openresty-openssl111-devel unzip pcre pcre-devel openldap-devel"
Review Comment:
utils/linux-install-luarocks.sh will execute wget command to get luarock tar file.
```bash
# utils/install-dependencies.sh
function install_luarocks() {
curl https://raw.githubusercontent.com/apache/apisix/master/utils/linux-install-luarocks.sh -sL | bash -
}
```
```bash
# utils/linux-install-luarocks.sh
wget https://github.com/luarocks/luarocks/archive/v"$LUAROCKS_VER".tar.gz
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #7092: fix: install dependencies issues
Posted by GitBox <gi...@apache.org>.
spacewander merged PR #7092:
URL: https://github.com/apache/apisix/pull/7092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] cr7258 commented on a diff in pull request #7092: fix: install dependencies issues
Posted by GitBox <gi...@apache.org>.
cr7258 commented on code in PR #7092:
URL: https://github.com/apache/apisix/pull/7092#discussion_r879056734
##########
utils/linux-install-luarocks.sh:
##########
@@ -53,5 +53,13 @@ if [ -d ${OPENRESTY_PREFIX}/openssl111 ]; then
OPENSSL_PREFIX=${OPENRESTY_PREFIX}/openssl111
fi
+FOUND_PATH=$(echo "${PATH}" | grep -oP '(?<=:|)/usr/local/bin(?=:|)') || true
+if [[ "${FOUND_PATH}" == "" ]]; then
+ echo "the path /usr/local/bin is not included in the system default PATH variable, add PATH variable in ~/.bashrc."
+ echo "export PATH=$PATH:/usr/local/bin" >> ~/.bashrc
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org