You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/08/11 14:44:44 UTC

[GitHub] [accumulo] milleruntime opened a new pull request #1675: Move MinorCompaction method call into retry catch block. Fixes #1298

milleruntime opened a new pull request #1675:
URL: https://github.com/apache/accumulo/pull/1675


   * Fixes the situation when MinorCompactionTask creates a
   new File and an IOException leaves the Tablet in a bad state
   * Moves the new file code into the try/catch block that will
   retry during an IOException
   
   I was not able to create a test for this scenario but I did simulate it by manually throwing the exception in the Tablet code.  I ran TableIT with the simulated IOException and it was able to recover.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] milleruntime merged pull request #1675: Move MinorCompaction method call into retry catch block. Fixes #1298

Posted by GitBox <gi...@apache.org>.
milleruntime merged pull request #1675:
URL: https://github.com/apache/accumulo/pull/1675


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] ctubbsii commented on pull request #1675: Move MinorCompaction method call into retry catch block. Fixes #1298

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1675:
URL: https://github.com/apache/accumulo/pull/1675#issuecomment-672396920


   FWIW, I ran all the ITs with this change, and everything passed (except a transient FateStarvationIT failure that is unrelated and which passed on a subsequent run).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] milleruntime commented on pull request #1675: Move MinorCompaction method call into retry catch block. Fixes #1298

Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #1675:
URL: https://github.com/apache/accumulo/pull/1675#issuecomment-672841180


   > FWIW, I ran all the ITs with this change, and everything passed (except a transient FateStarvationIT failure that is unrelated and which passed on a subsequent run).
   
   Great thank you!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org