You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "f1amingo (via GitHub)" <gi...@apache.org> on 2023/05/25 06:00:09 UTC
[GitHub] [rocketmq-clients] f1amingo opened a new pull request, #522: fix: setGroup() invoked twice when wrapAckMessageRequest()
f1amingo opened a new pull request, #522:
URL: https://github.com/apache/rocketmq-clients/pull/522
<!-- Please make sure the target branch is right. In most case, the target branch should be `master`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
This modification is trivial, so I didn't create an issue.
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
When build `AckMessageRequest` in `wrapAckMessageRequest()` ` setGroup()` has been invoked twice, which is unnecessary.
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
no need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] aaron-ai commented on pull request #522: fix: setGroup() invoked twice when wrapAckMessageRequest()
Posted by "aaron-ai (via GitHub)" <gi...@apache.org>.
aaron-ai commented on PR #522:
URL: https://github.com/apache/rocketmq-clients/pull/522#issuecomment-1562332904
Nice catch! Thanks @f1amingo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] aaron-ai merged pull request #522: fix: setGroup() invoked twice when wrapAckMessageRequest()
Posted by "aaron-ai (via GitHub)" <gi...@apache.org>.
aaron-ai merged PR #522:
URL: https://github.com/apache/rocketmq-clients/pull/522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] codecov-commenter commented on pull request #522: fix: setGroup() invoked twice when wrapAckMessageRequest()
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #522:
URL: https://github.com/apache/rocketmq-clients/pull/522#issuecomment-1562331994
## [Codecov](https://app.codecov.io/gh/apache/rocketmq-clients/pull/522?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#522](https://app.codecov.io/gh/apache/rocketmq-clients/pull/522?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7b21d99) into [master](https://app.codecov.io/gh/apache/rocketmq-clients/commit/c3f2b69e50a659a7ef9ac84888207d8046a2abfe?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c3f2b69) will **not change** coverage.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #522 +/- ##
=========================================
Coverage 45.84% 45.84%
Complexity 659 659
=========================================
Files 207 207
Lines 11452 11452
Branches 2892 2892
=========================================
Hits 5250 5250
Misses 5976 5976
Partials 226 226
```
| Flag | Coverage Δ | |
|---|---|---|
| java | `62.65% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/rocketmq-clients/pull/522?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...cketmq/client/java/impl/consumer/ConsumerImpl.java](https://app.codecov.io/gh/apache/rocketmq-clients/pull/522?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvY29uc3VtZXIvQ29uc3VtZXJJbXBsLmphdmE=) | `73.10% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org