You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2019/08/27 17:46:54 UTC
svn commit: r1865998 -
/pdfbox/branches/issue4569/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java
Author: tilman
Date: Tue Aug 27 17:46:54 2019
New Revision: 1865998
URL: http://svn.apache.org/viewvc?rev=1865998&view=rev
Log:
PDFBOX-4638: refactor and treat empty BBox like a missing BBox
Modified:
pdfbox/branches/issue4569/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java
Modified: pdfbox/branches/issue4569/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/issue4569/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java?rev=1865998&r1=1865997&r2=1865998&view=diff
==============================================================================
--- pdfbox/branches/issue4569/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java (original)
+++ pdfbox/branches/issue4569/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java Tue Aug 27 17:46:54 2019
@@ -208,8 +208,7 @@ class AppearanceGeneratorHelper
// TODO support appearances other than "normal"
PDAppearanceStream appearanceStream;
- if (appearance != null && appearance.isStream() &&
- appearance.getAppearanceStream().getBBox() != null)
+ if (isValidAppearanceStream(appearance))
{
appearanceStream = appearance.getAppearanceStream();
}
@@ -240,6 +239,24 @@ class AppearanceGeneratorHelper
}
}
+ private static boolean isValidAppearanceStream(PDAppearanceEntry appearance)
+ {
+ if (appearance == null)
+ {
+ return false;
+ }
+ if (!appearance.isStream())
+ {
+ return false;
+ }
+ PDRectangle bbox = appearance.getAppearanceStream().getBBox();
+ if (bbox == null)
+ {
+ return false;
+ }
+ return Math.abs(bbox.getWidth()) > 0 && Math.abs(bbox.getHeight()) > 0;
+ }
+
private PDAppearanceStream prepareNormalAppearanceStream(PDAnnotationWidget widget)
{
PDAppearanceStream appearanceStream = new PDAppearanceStream(field.getAcroForm().getDocument());