You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jordan Birdsell (Code Review)" <ge...@cloudera.org> on 2016/11/15 05:19:49 UTC
[kudu-CR] [python] - Fix bug with Python 3 in ColumnSpec.rename method
Jordan Birdsell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5087
Change subject: [python] - Fix bug with Python 3 in ColumnSpec.rename method
......................................................................
[python] - Fix bug with Python 3 in ColumnSpec.rename method
The rename method in the ColumnSpec class is not properly converting
strings to bytes, which adversly impacts only Python 3 since Python
3 treats strings and byte strings differently. This patch adds the
appropriate tobytes() method call in the ColumnSpec class and removes
the unecessary one from the AlterTable class.
Change-Id: Ia8b178af9baa44c7c3f31ceab604d68785890683
---
M python/kudu/client.pyx
M python/kudu/schema.pyx
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/5087/1
--
To view, visit http://gerrit.cloudera.org:8080/5087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8b178af9baa44c7c3f31ceab604d68785890683
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
[kudu-CR] [python] - Fix bug with Python 3 in ColumnSpec.rename method
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: [python] - Fix bug with Python 3 in ColumnSpec.rename method
......................................................................
[python] - Fix bug with Python 3 in ColumnSpec.rename method
The rename method in the ColumnSpec class is not properly converting
strings to bytes, which adversly impacts only Python 3 since Python
3 treats strings and byte strings differently. This patch adds the
appropriate tobytes() method call in the ColumnSpec class and removes
the unecessary one from the AlterTable class.
Change-Id: Ia8b178af9baa44c7c3f31ceab604d68785890683
Reviewed-on: http://gerrit.cloudera.org:8080/5087
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M python/kudu/client.pyx
M python/kudu/schema.pyx
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8b178af9baa44c7c3f31ceab604d68785890683
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [python] - Fix bug with Python 3 in ColumnSpec.rename method
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [python] - Fix bug with Python 3 in ColumnSpec.rename method
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8b178af9baa44c7c3f31ceab604d68785890683
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No