[GitHub] kamaci commented on a change in pull request #6943: InterruptedExceptions should never be ignored in the code.

[GitBox <gi...@apache.org>]

kamaci commented on a change in pull request #6943: InterruptedExceptions should never be ignored in the code.
URL: https://github.com/apache/incubator-druid/pull/6943#discussion_r251831675
 
 

 ##########
 File path: extensions-contrib/druid-rocketmq/src/main/java/org/apache/druid/firehose/rocketmq/RocketMQFirehoseFactory.java
 ##########
 @@ -498,6 +502,7 @@ public void run()
       }
       catch (InterruptedException e) {
         LOGGER.error(e, "");
+        Thread.currentThread().interrupt();
 
 Review comment:
   Logging can be done before cleaning up the method's state after logging too. However, I can change it to place at first line?
   
   For Intellij IDEA, I can check it to include at Checkstyle. On the other hand, I can fix #6701 too?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org