You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Norman Maurer (JIRA)" <se...@james.apache.org> on 2010/11/15 22:12:56 UTC

[jira] Created: (JAMES-1135) fetchmail does not handle isLocalRecipient correctly

fetchmail does not handle isLocalRecipient correctly
----------------------------------------------------

                 Key: JAMES-1135
                 URL: https://issues.apache.org/jira/browse/JAMES-1135
             Project: JAMES Server
          Issue Type: Bug
    Affects Versions: 3.0-M2, 3.0-M1
            Reporter: Norman Maurer
             Fix For: 3.0-M3


>From ML:


In MessageProcessor.java:

   /**
    * Method isLocalRecipient.
    * @param recipient
    * @return boolean
    */
   protected boolean isLocalRecipient(MailAddress recipient)
   {
       return isLocalServer(recipient) && getLocalUsers().contains(recipient.toString());
   }

should be:

   /**
    * Method isLocalRecipient.
    * @param recipient
    * @return boolean
    */
   protected boolean isLocalRecipient(MailAddress recipient)
   {
       return isLocalServer(recipient) && getLocalUsers().contains(recipient.getLocalPart());
   }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Updated: (JAMES-1135) fetchmail does not handle isLocalRecipient correctly

Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
     [ https://issues.apache.org/jira/browse/JAMES-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Norman Maurer updated JAMES-1135:
---------------------------------

    Component/s: FetchMail

> fetchmail does not handle isLocalRecipient correctly
> ----------------------------------------------------
>
>                 Key: JAMES-1135
>                 URL: https://issues.apache.org/jira/browse/JAMES-1135
>             Project: JAMES Server
>          Issue Type: Bug
>          Components: FetchMail
>    Affects Versions: 3.0-M1, 3.0-M2
>            Reporter: Norman Maurer
>             Fix For: 3.0-M3
>
>
> From ML:
> In MessageProcessor.java:
>    /**
>     * Method isLocalRecipient.
>     * @param recipient
>     * @return boolean
>     */
>    protected boolean isLocalRecipient(MailAddress recipient)
>    {
>        return isLocalServer(recipient) && getLocalUsers().contains(recipient.toString());
>    }
> should be:
>    /**
>     * Method isLocalRecipient.
>     * @param recipient
>     * @return boolean
>     */
>    protected boolean isLocalRecipient(MailAddress recipient)
>    {
>        return isLocalServer(recipient) && getLocalUsers().contains(recipient.getLocalPart());
>    }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Updated: (JAMES-1135) fetchmail does not handle isLocalRecipient correctly

Posted by "Toël Hartmann (JIRA)" <se...@james.apache.org>.
     [ https://issues.apache.org/jira/browse/JAMES-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Toël Hartmann updated JAMES-1135:
---------------------------------

    Attachment: vcs-diff1047350971741563426.patch

Fix for local recipient check

> fetchmail does not handle isLocalRecipient correctly
> ----------------------------------------------------
>
>                 Key: JAMES-1135
>                 URL: https://issues.apache.org/jira/browse/JAMES-1135
>             Project: JAMES Server
>          Issue Type: Bug
>          Components: FetchMail
>    Affects Versions: 3.0-M1, 3.0-M2
>            Reporter: Norman Maurer
>             Fix For: 3.0-M3
>
>         Attachments: vcs-diff1047350971741563426.patch
>
>
> From ML:
> In MessageProcessor.java:
>    /**
>     * Method isLocalRecipient.
>     * @param recipient
>     * @return boolean
>     */
>    protected boolean isLocalRecipient(MailAddress recipient)
>    {
>        return isLocalServer(recipient) && getLocalUsers().contains(recipient.toString());
>    }
> should be:
>    /**
>     * Method isLocalRecipient.
>     * @param recipient
>     * @return boolean
>     */
>    protected boolean isLocalRecipient(MailAddress recipient)
>    {
>        return isLocalServer(recipient) && getLocalUsers().contains(recipient.getLocalPart());
>    }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Resolved: (JAMES-1135) fetchmail does not handle isLocalRecipient correctly

Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
     [ https://issues.apache.org/jira/browse/JAMES-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Norman Maurer resolved JAMES-1135.
----------------------------------

    Resolution: Fixed
      Assignee: Norman Maurer

Fixed.. thanks again for the report and fix.

Please review:

http://svn.apache.org/viewvc/james/server/trunk/fetchmail/src/main/java/org/apache/james/fetchmail/MessageProcessor.java?r1=1032368&r2=1035583&pathrev=1035583

> fetchmail does not handle isLocalRecipient correctly
> ----------------------------------------------------
>
>                 Key: JAMES-1135
>                 URL: https://issues.apache.org/jira/browse/JAMES-1135
>             Project: JAMES Server
>          Issue Type: Bug
>          Components: FetchMail
>    Affects Versions: 3.0-M1, 3.0-M2
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>             Fix For: 3.0-M3
>
>         Attachments: vcs-diff1047350971741563426.patch
>
>
> From ML:
> In MessageProcessor.java:
>    /**
>     * Method isLocalRecipient.
>     * @param recipient
>     * @return boolean
>     */
>    protected boolean isLocalRecipient(MailAddress recipient)
>    {
>        return isLocalServer(recipient) && getLocalUsers().contains(recipient.toString());
>    }
> should be:
>    /**
>     * Method isLocalRecipient.
>     * @param recipient
>     * @return boolean
>     */
>    protected boolean isLocalRecipient(MailAddress recipient)
>    {
>        return isLocalServer(recipient) && getLocalUsers().contains(recipient.getLocalPart());
>    }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org