You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@linkis.apache.org by rita <ri...@163.com> on 2022/08/15 11:06:32 UTC
[DISCUSS]Linkis website issue processing and PR merger issues
Dear:
The chat records of WeChat group“Apache linkis Community Development
Group”are as follows微信群"Apache Linkis 社区开发群"的聊天记录如下
casion 17:35
Linkis web issue
1.计划移除官网 https://linkis.apache.org/ 主页菜单栏 避免中等屏幕部分菜单显
示拥挤/不全问题
1. Plan to remove the website https://linkis.apache.org/ home page menu bar
Avoid secondary part of the menu display screen crowded/no problem
https://github.com/apache/incubator-linkis/issues/2755
https://github.com/apache/incubator-linkis/issues/2755
2 浏览器刷新访问url 会自动在url中添加/问题 导致文档中的相对路径识别失败 404
问题
2 When the browser refreshes the URL, a/error is automatically added to the
URL, which results in a failure to identify the relative path in the
document
https://github.com/apache/incubator-linkis/issues/2754
https://github.com/apache/incubator-linkis/issues/2754
casion 17:36
欢迎有兴趣的同学 帮解决贡献pr
Welcome interested students to help solve the PR contribution
peacewong@WDS 18:32
@jackxu2011_麟云 许灵兄 PR有冲突来着:
https://github.com/apache/incubator-linkis/pull/2736
@ jackxu2011_ 'cloud Brother Xu Ling PR has conflict did:
https://github.com/apache/incubator-linkis/pull/2736
peacewong@WDS 18:32
@legendtkl @夏晨 克路兄和夏晨兄 帮忙review下
@legendtkl @Brother Xia Chenke Lu and Brother Xia Chen help review
legendtkl 18:32
ok
casion 18:33
这个格式化调整要不提到1.3.0分支吧
This formatting adjustment should not mention the 1.3.0 branch
peacewong@WDS 18:34
也可以,1.2.0已经测试中了
Yes, 1.2.0 is already being tested
legendtkl 18:34
可以的
Can the
许灵 18:55
Xu Ling 18:55
今天有内容合并,所以冲突了
There was a content merge today, so there was a conflict
许灵 18:57
Xu Ling 18:57
格式化,还是尽快吧,不然这个一直有问题,从1.1.3就说要弄了
Formatting, or as soon as possible, otherwise this has been a problem, from
1.1.3 said to do
许灵 18:59
Xu Ling 18:59
这已经是第二次提了,格式化冲突不弄好,这个冲突会一直存在的
This is the second time to mention, formatting conflict is not properly,
this conflict will always exist
peacewong@WDS 19:05
是的,直接提交到1.3.0没问题就合并了。
Yes, commit directly to 1.3.0 and merge without a problem.
许灵 19:08
Xu Ling 19:08
我晚上看一下
I'll take a look at it tonight
peacewong@WDS 19:08
好的
good
许灵 19:12
Xu Ling then
1.2.0是不是要先合一下到1.3.0
Should 1.2.0 merge to 1.3.0 first
peacewong@WDS 19:12
是的,我来搞下
Yeah, I'll get it
许灵 19:13
Xu Ling nobleman
Ok
peacewong@WDS 21:48
许灵兄 可以了
Brother Xu Ling is ready
许灵 22:17
Xu Ling"
ok, 我已经在编译代码了
Ok, I'm already compiling the code
许灵 22:58
Xu Ling after
pr刚重新提交 https://github.com/apache/incubator-linkis/pull/2761
Pr just resubmit https://github.com/apache/incubator-linkis/pull/2761
legendtkl 22:59
等 github CI 完成之后 merge
Merge after Github CI is complete
――――― 2022-8-14 ―――――
peacewong@WDS 00:21
有几处Spark需要修改下
There are several Spark changes that need to be made
peacewong@WDS 00:22
As of SPARK-的注释这几个是不是要移除下
"As of SPARK-" should be removed
许灵 06:52
Xu Ling 06:52
这个我当时看了,这个是对于写spark测试的约束,保留是可以的
I read this at the time. This is a constraint for writing Spark tests, and
it is OK to keep it
许灵 06:56
Xu Ling 06:56
我今天白天有事。
I have something to do during the day.
如果确认要去掉,等我晚上改一下,或者下次补提一个pr
If you are sure to remove it, wait for me to change it tonight, or make up a
PR next time
peacewong@WDS 08:55
嗯嗯,建议去掉下
Yeah, yeah, I suggest you get rid of it