You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/19 07:22:28 UTC
[GitHub] [incubator-nuttx] btashton opened a new pull request #1423: Use AVR Linux toolchain instead of buildroot in default configs
btashton opened a new pull request #1423:
URL: https://github.com/apache/incubator-nuttx/pull/1423
## Summary
Update all the included configs to build using the "Linux" AVR tools so we can easily test on windows instead of the buildroot toolchains. Also refresh some other configuration settings.
## Testing
All of the AVR configurations were built successfully
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1423: Use AVR Linux toolchain instead of buildroot in default configs
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #1423:
URL: https://github.com/apache/incubator-nuttx/pull/1423#discussion_r456917480
##########
File path: boards/avr/at90usb/micropendous3/configs/hello/defconfig
##########
@@ -13,7 +13,7 @@ CONFIG_ARCH_CHIP="at90usb"
CONFIG_ARCH_CHIP_AT90USB647=y
CONFIG_ARCH_CHIP_AT90USB=y
CONFIG_ARCH_STACKDUMP=y
-CONFIG_AVR_BUILDROOT_TOOLCHAIN=y
+CONFIG_AVR_LINUXGCC_TOOLCHAIN=y
Review comment:
This requires building the NuttX buildroot toolchain which we are not doing for any of the other boards yet either.
Might be worth adding to a nightly build flow or something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1423: Use AVR Linux toolchain instead of buildroot in default configs
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1423:
URL: https://github.com/apache/incubator-nuttx/pull/1423#issuecomment-660665582
Are you guys going to address the warnings in this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1423: Use AVR Linux toolchain instead of buildroot in default configs
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1423:
URL: https://github.com/apache/incubator-nuttx/pull/1423#issuecomment-660682044
All my local tests are passing for this using our CI docker container.
```
root@91193c0e0a31:/src/nuttx# ./tools/testbuild.sh -l -j 8 ../avr.dat
====================================================================================
Configuration/Tool: arduino-mega2560/hello
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Building NuttX...
Normalize arduino-mega2560/hello
====================================================================================
Configuration/Tool: arduino-mega2560/nsh
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Building NuttX...
Normalize arduino-mega2560/nsh
====================================================================================
Configuration/Tool: amber/hello
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Building NuttX...
Normalize amber/hello
====================================================================================
Configuration/Tool: moteino-mega/hello
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Building NuttX...
Normalize moteino-mega/hello
====================================================================================
Configuration/Tool: moteino-mega/nsh
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Building NuttX...
Normalize moteino-mega/nsh
====================================================================================
Configuration/Tool: teensy-2.0/hello
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Building NuttX...
Normalize teensy-2.0/hello
====================================================================================
Configuration/Tool: teensy-2.0/nsh
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Building NuttX...
Normalize teensy-2.0/nsh
====================================================================================
Configuration/Tool: teensy-2.0/usbmsc
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Building NuttX...
Normalize teensy-2.0/usbmsc
====================================================================================
Configuration/Tool: micropendous3/hello
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Building NuttX...
Normalize micropendous3/hello
====================================================================================
Skipping: avr32dev1/nsh
====================================================================================
Skipping: avr32dev1/ostest
====================================================================================
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1423: Use AVR Linux toolchain instead of buildroot in default configs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1423:
URL: https://github.com/apache/incubator-nuttx/pull/1423#discussion_r456900669
##########
File path: boards/avr/at90usb/micropendous3/configs/hello/defconfig
##########
@@ -13,7 +13,7 @@ CONFIG_ARCH_CHIP="at90usb"
CONFIG_ARCH_CHIP_AT90USB647=y
CONFIG_ARCH_CHIP_AT90USB=y
CONFIG_ARCH_STACKDUMP=y
-CONFIG_AVR_BUILDROOT_TOOLCHAIN=y
Review comment:
Should we test buildroot toolchain too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #1423: Fixes for AVR support required for builds to pass CI
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #1423:
URL: https://github.com/apache/incubator-nuttx/pull/1423
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #1423: Use AVR Linux toolchain instead of buildroot in default configs
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1423:
URL: https://github.com/apache/incubator-nuttx/pull/1423#issuecomment-660676823
> Yeah and there are a few more warnings. Once I have the compile warnings fixed I'll take care of the style fixes.
Brennan, why avr 8-bit (not avr32) is still trying to build and failing:
Configuration/Tool: arduino-mega2560/hello
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Building NuttX...
sh: 1: avr-nuttx-elf-gcc: not found
sh: 1: ERROR: avr-nuttx-elf-gcc failed: 127
command: avr-nuttx-elf-gcc -MT ./hello_main.github.workspace.sources.apps.examples.hello.o -M '-fno-builtin' '-Wall' '-Wstrict-prototypes' '-Wshadow' '-Wundef' '-g3' '-O2' '-fno-strict-aliasing' '-fno-strength-reduce' '-fomit-frame-pointer' '-mmcu=atmega2560' '-isystem' '/github/workspace/sources/nuttx/include' '-D__KERNEL__' '-Wno-cpp' '-Werror' '-pipe' '-I' '/github/workspace/sources/apps/include' ./hello_main.c
avr-nuttx-elf-gcc: not found
ERROR: avr-nuttx-elf-gcc failed: 127
Configuration/Tool: arduino-mega2560/nsh
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Building NuttX...
sh: 1: avr-nuttx-elf-gcc: not found
sh: 1: avr-nuttx-elf-gcc: not found
ERROR: avr-nuttx-elf-gcc failed: 127
command: avr-nuttx-elf-gcc -MT ./readline.github.workspace.sources.apps.system.readline.o -M '-fno-builtin' '-Wall' '-Wstrict-prototypes' '-Wshadow' '-Wundef' '-g3' '-O2' '-fno-strict-aliasing' '-fno-strength-reduce' '-fomit-frame-pointer' '-mmcu=atmega2560' '-isystem' '/github/workspace/sources/nuttx/include' '-D__KERNEL__' '-Wno-cpp' '-Werror' '-pipe' '-I' '/github/workspace/sources/apps/include' ./readline.c
make[2]: *** [/github/workspace/sources/apps/Application.mk:230: .depend] Error 1
make[1]: *** [Makefile:55: /github/workspace/sources/apps/system/readline_depend] Error 2
make[1]: *** Waiting for unfinished jobs....
ERROR: avr-nuttx-elf-gcc failed: 127
Configuration/Tool: amber/hello
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Building NuttX...
sh: 1: avr-nuttx-elf-gcc: not found
ERROR: avr-nuttx-elf-gcc failed: 127
command: avr-nuttx-elf-gcc -MT ./hello_main.github.workspace.sources.apps.examples.hello.o -M '-fno-builtin' '-Wall' '-Wstrict-prototypes' '-Wshadow' '-Wundef' '-O2' '-fno-strict-aliasing' '-fno-strength-reduce' '-fomit-frame-pointer' '-mmcu=atmega128' '-isystem' '/github/workspace/sources/nuttx/include' '-D__KERNEL__' '-Wno-cpp' '-Werror' '-pipe' '-I' '/github/workspace/sources/apps/include' ./hello_main.c
sh: 1: avr-nuttx-elf-gcc: not found
ERROR: avr-nuttx-elf-gcc failed: 127
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1423: Use AVR Linux toolchain instead of buildroot in default configs
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1423:
URL: https://github.com/apache/incubator-nuttx/pull/1423#issuecomment-660666034
> Are you guys going to address the warnings in this PR?
I'm trying to fix some of the warnings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1423: Use AVR Linux toolchain instead of buildroot in default configs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1423:
URL: https://github.com/apache/incubator-nuttx/pull/1423#discussion_r456932621
##########
File path: arch/avr/src/avr/up_schedulesigaction.c
##########
@@ -152,13 +153,15 @@ void up_schedule_sigaction(struct tcb_s *tcb, sig_deliver_t sigdeliver)
/* Then set up to vector to the trampoline with interrupts
* disabled
*/
+
+ reg_ptr = (uintptr_t)up_sigdeliver;
#if !defined(REG_PC2)
- g_current_regs[REG_PC0] = (uint16_t)up_sigdeliver >> 8;
- g_current_regs[REG_PC1] = (uint16_t)up_sigdeliver & 0xff;
+ g_current_regs[REG_PC0] = (uint16_t)up_sigdeliver >> 8;
+ g_current_regs[REG_PC1] = (uint16_t)up_sigdeliver & 0xff;
Review comment:
should we use reg_ptr too?
##########
File path: arch/avr/src/avr/up_schedulesigaction.c
##########
@@ -152,13 +153,15 @@ void up_schedule_sigaction(struct tcb_s *tcb, sig_deliver_t sigdeliver)
/* Then set up to vector to the trampoline with interrupts
* disabled
*/
+
+ reg_ptr = (uintptr_t)up_sigdeliver;
Review comment:
We can directly init reg_ptr at line 94, then both line 157 and 201 can be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1423: Use AVR Linux toolchain instead of buildroot in default configs
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #1423:
URL: https://github.com/apache/incubator-nuttx/pull/1423#discussion_r456935205
##########
File path: .github/workflows/build.yml
##########
@@ -181,6 +181,7 @@ jobs:
run: |
echo "::add-matcher::sources/nuttx/.github/gcc.json"
cd sources/testing
+ echo -e "/avr\n-avr32dev1:nsh\n-avr32dev1:ostest" >> testlist/avr-mips-riscv-x86-xtensa.dat
Review comment:
This will be removed once the CI passes. This should force building of the AVR targets
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #1423: Use AVR Linux toolchain instead of buildroot in default configs
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1423:
URL: https://github.com/apache/incubator-nuttx/pull/1423#issuecomment-660659044
Hi @xiaoxiang781216 @btashton it is reporting "error: left shift count >= width of type"
Could you please apply this patch:
`[PATCH] Fix error: left shift count >= width of type
---
libs/libc/net/lib_inetaddr.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/libs/libc/net/lib_inetaddr.c b/libs/libc/net/lib_inetaddr.c
index e71ee8e011..1b6db62bc4 100644
--- a/libs/libc/net/lib_inetaddr.c
+++ b/libs/libc/net/lib_inetaddr.c
@@ -102,7 +102,7 @@ in_addr_t inet_addr(FAR const char *cp)
{
if ((a < 0x100) && (b < 0x1000000))
{
- result = (a << 24) | b;
+ result = (((uint32_t) a) << 24) | b;
}
break;
}
@@ -111,7 +111,7 @@ in_addr_t inet_addr(FAR const char *cp)
{
if ((a < 0x100) && (b < 0x100) && (c < 0x10000))
{
- result = (a << 24) | (b << 16) | c;
+ result = (((uint32_t) a) << 24) | (((uint32_t) b) << 16) | c;
}
break;
}
@@ -120,7 +120,8 @@ in_addr_t inet_addr(FAR const char *cp)
{
if ((a < 0x100) && (b < 0x100) && (c < 0x100) && (d < 0x100))
{
- result = (a << 24) | (b << 16) | (c << 8) | d;
+ result = (((uint32_t) a) << 24) | (((uint32_t) b) << 16) |
+ (((uint32_t) c) << 8) | d;
}
break;
}
--
2.25.1`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #1423: Use AVR Linux toolchain instead of buildroot in default configs
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1423:
URL: https://github.com/apache/incubator-nuttx/pull/1423#issuecomment-660673670
More errors when trying to compile:
6b2f90bc9c libc: Typecast to avoid overflow in inet_addr for AVR
0cd16bacc9 Use AVR Linux toolchain instead of buildroot
../nuttx/tools/checkpatch.sh -g f66ead9ca36ab9eefa72b73a97cd14c581af07c3..fb5b9c42a86d308c1e5bedb4463387dde1df68d6
##[error]/home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/avr/src/avr/up_schedulesigaction.c:140:79: error: Long line found
##[error]/home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/avr/src/avr/up_schedulesigaction.c:155:1: error: Missing blank line after comment
##[error]/home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/avr/src/avr/up_schedulesigaction.c:156:0: error: TABs found. First detected
##[error]/home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/avr/src/avr/up_schedulesigaction.c:198:1: error: Missing blank line after comment
##[error]/home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/avr/src/common/up_internal.h:92:78: error: Long line found
##[error]/home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/avr/src/common/up_internal.h:93:80: error: Long line found
##[error]/home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/avr/src/common/up_internal.h:98:78: error: Long line found
##[error]/home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/avr/src/common/up_internal.h:119:3: error: Invalid section for this file type
##[error]Process completed with exit code 1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis edited a comment on pull request #1423: Use AVR Linux toolchain instead of buildroot in default configs
Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #1423:
URL: https://github.com/apache/incubator-nuttx/pull/1423#issuecomment-660659044
Hi @xiaoxiang781216 @btashton it is reporting "error: left shift count >= width of type"
Could you please apply this patch:
<pre>
[PATCH] Fix error: left shift count >= width of type
---
libs/libc/net/lib_inetaddr.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/libs/libc/net/lib_inetaddr.c b/libs/libc/net/lib_inetaddr.c
index e71ee8e011..1b6db62bc4 100644
--- a/libs/libc/net/lib_inetaddr.c
+++ b/libs/libc/net/lib_inetaddr.c
@@ -102,7 +102,7 @@ in_addr_t inet_addr(FAR const char *cp)
{
if ((a < 0x100) && (b < 0x1000000))
{
- result = (a << 24) | b;
+ result = (((uint32_t) a) << 24) | b;
}
break;
}
@@ -111,7 +111,7 @@ in_addr_t inet_addr(FAR const char *cp)
{
if ((a < 0x100) && (b < 0x100) && (c < 0x10000))
{
- result = (a << 24) | (b << 16) | c;
+ result = (((uint32_t) a) << 24) | (((uint32_t) b) << 16) | c;
}
break;
}
@@ -120,7 +120,8 @@ in_addr_t inet_addr(FAR const char *cp)
{
if ((a < 0x100) && (b < 0x100) && (c < 0x100) && (d < 0x100))
{
- result = (a << 24) | (b << 16) | (c << 8) | d;
+ result = (((uint32_t) a) << 24) | (((uint32_t) b) << 16) |
+ (((uint32_t) c) << 8) | d;
}
break;
}
--
2.25.1
</pre>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1423: Use AVR Linux toolchain instead of buildroot in default configs
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #1423:
URL: https://github.com/apache/incubator-nuttx/pull/1423#discussion_r456935093
##########
File path: fs/driver/fs_blockpartition.c
##########
@@ -224,6 +224,7 @@ static int part_geometry(FAR struct inode *inode, struct geometry *geometry)
static int part_ioctl(FAR struct inode *inode, int cmd, unsigned long arg)
{
+ FAR uintptr_t ptr_arg = (uintptr_t)arg;
Review comment:
@xiaoxiang781216 I took care of this here because it is used in the AVR build, but we should probably do something like this in most of the ioctl that take a pointer as an argument. This should be harmless since it is really just being explicit about the cast. Just adding the cast everywhere in the function makes for long lines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1423: Use AVR Linux toolchain instead of buildroot in default configs
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1423:
URL: https://github.com/apache/incubator-nuttx/pull/1423#issuecomment-660660399
Thanks Alan. I'm going to open a couple PRs now to get things working again on the builds until we get the rest of the warnings fixed. Things are a little brittle enabling new set of boards so sorry about that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1423: Use AVR Linux toolchain instead of buildroot in default configs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1423:
URL: https://github.com/apache/incubator-nuttx/pull/1423#discussion_r456900788
##########
File path: boards/avr/at90usb/micropendous3/configs/hello/defconfig
##########
@@ -13,7 +13,7 @@ CONFIG_ARCH_CHIP="at90usb"
CONFIG_ARCH_CHIP_AT90USB647=y
CONFIG_ARCH_CHIP_AT90USB=y
CONFIG_ARCH_STACKDUMP=y
-CONFIG_AVR_BUILDROOT_TOOLCHAIN=y
+CONFIG_AVR_LINUXGCC_TOOLCHAIN=y
Review comment:
Should we test buildroot toolchain too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #1423: Use AVR Linux toolchain instead of buildroot in default configs
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1423:
URL: https://github.com/apache/incubator-nuttx/pull/1423#issuecomment-660661070
> Thanks Alan. I'm going to open a couple PRs now to get things working again on the builds until we get the rest of the warnings fixed. Things are a little brittle enabling new set of boards so sorry about that.
Thank you Brennan! No problem, it happens. Maybe we need to find a way to get new boards addition more smooth.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #1423: Use AVR Linux toolchain instead of buildroot in default configs
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1423:
URL: https://github.com/apache/incubator-nuttx/pull/1423#issuecomment-660677030
I didn't find other place where avr still called, probably some other place needs to be commented, but I didn't find it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1423: Use AVR Linux toolchain instead of buildroot in default configs
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1423:
URL: https://github.com/apache/incubator-nuttx/pull/1423#issuecomment-660677485
> I didn't find other place where avr still called, probably some other place needs to be commented, but I didn't find it.
There was a config defaulting to mac that I did not catch and update. Should be good now on that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1423: Use AVR Linux toolchain instead of buildroot in default configs
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1423:
URL: https://github.com/apache/incubator-nuttx/pull/1423#issuecomment-660673873
Yeah and there are a few more warnings. Once I have the compile warnings fixed I'll take care of the style fixes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org