You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/06/01 07:54:14 UTC
[GitHub] [brooklyn-ui] algairim commented on a change in pull request #207: Improve focus handling in spec-editor directive
algairim commented on a change in pull request #207:
URL: https://github.com/apache/brooklyn-ui/pull/207#discussion_r642867174
##########
File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js
##########
@@ -181,6 +187,10 @@ export function specEditorDirective($rootScope, $templateCache, $injector, $sani
}
};
+ scope.state = sessionStorage && sessionStorage.getItem(scope.model._id)
+ ? JSON.parse(sessionStorage.getItem(scope.model._id))
+ : defaultState;
Review comment:
Moved up to enable external configuration, e.g. branding.
##########
File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js
##########
@@ -181,6 +187,10 @@ export function specEditorDirective($rootScope, $templateCache, $injector, $sani
}
};
+ scope.state = sessionStorage && sessionStorage.getItem(scope.model._id)
+ ? JSON.parse(sessionStorage.getItem(scope.model._id))
+ : defaultState;
Review comment:
Moved up to enable external configuration of the state, e.g. branding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org