You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2011/02/23 09:46:59 UTC

svn commit: r1073642 - /wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/link/ExternalLink.java

Author: mgrigorov
Date: Wed Feb 23 08:46:59 2011
New Revision: 1073642

URL: http://svn.apache.org/viewvc?rev=1073642&view=rev
Log:
WICKET-3469 Referrer Leaking with ExternalLink

Add a javadoc explaining the possible problem.

Modified:
    wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/link/ExternalLink.java

Modified: wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/link/ExternalLink.java
URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/link/ExternalLink.java?rev=1073642&r1=1073641&r2=1073642&view=diff
==============================================================================
--- wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/link/ExternalLink.java (original)
+++ wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/link/ExternalLink.java Wed Feb 23 08:46:59 2011
@@ -16,6 +16,7 @@
  */
 package org.apache.wicket.markup.html.link;
 
+import org.apache.wicket.RedirectToUrlException;
 import org.apache.wicket.RequestCycle;
 import org.apache.wicket.markup.ComponentTag;
 import org.apache.wicket.markup.MarkupStream;
@@ -24,8 +25,16 @@ import org.apache.wicket.model.Model;
 import org.apache.wicket.util.string.Strings;
 
 /**
+ * <p>
  * A simple anchor link (&lt;a href="http://url"&gt;) pointing to any URL. Usually this is used for
  * links to destinations outside of Wicket.
+ * </p>
+ * 
+ * <p>
+ * <strong>Note</strong>: in the case when the support for cookies in the browser is disabled the
+ * user's jsessionid will leak in the 'Referrer' header after clicking this link. If this is a
+ * problem for the application then better use {@link Link} which redirects to the new URL using
+ * {@link RedirectToUrlException}.
  * 
  * @author Juergen Donnerstag
  */