You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Dmitry Lychagin (Code Review)" <de...@asterixdb.apache.org> on 2019/06/01 01:09:44 UTC

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Dmitry Lychagin has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/3420


Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................

[NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Improve error message raised when EXPLAIN
  is not supported for a given statement

Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
---
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.1.ddl.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.2.query.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.3.query.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.4.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
6 files changed, 124 insertions(+), 13 deletions(-)



  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/20/3420/1

diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.1.ddl.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.1.ddl.sqlpp
new file mode 100644
index 0000000..741c9be
--- /dev/null
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.1.ddl.sqlpp
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/*
+ * Description: EXPLAIN not supported for statement kind
+ */
+
+DROP DATAVERSE dvExplain IF EXISTS;
+CREATE DATAVERSE dvExplain;
+
+USE dvExplain;
+
+CREATE TYPE EmployeeType AS {
+  id : string,
+  x  : string
+};
+
+CREATE DATASET Employee(EmployeeType) PRIMARY KEY id;
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.2.query.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.2.query.sqlpp
new file mode 100644
index 0000000..a309a92
--- /dev/null
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.2.query.sqlpp
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/*
+ * Description  : EXPLAIN not supported for CREATE DATAVERSE
+ * Expected Res : Failure
+ */
+
+EXPLAIN CREATE DATAVERSE dvExplain2;
\ No newline at end of file
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.3.query.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.3.query.sqlpp
new file mode 100644
index 0000000..11fe3d2
--- /dev/null
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.3.query.sqlpp
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/*
+ * Description  : EXPLAIN not supported for CREATE DATASET
+ * Expected Res : Failure
+ */
+
+USE dvExplain;
+
+EXPLAIN CREATE DATASET Employee2(EmployeeType) PRIMARY KEY id;
\ No newline at end of file
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.4.query.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.4.query.sqlpp
new file mode 100644
index 0000000..9f74ef8
--- /dev/null
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.4.query.sqlpp
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/*
+ * Description  : EXPLAIN not supported for CREATE INDEX
+ * Expected Res : Failure
+ */
+
+USE dvExplain;
+
+EXPLAIN CREATE INDEX idx1 on Employee(x) type btree;
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
index d5fa013..2e7adfd 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
@@ -174,6 +174,14 @@
         <output-dir compare="Text">explain_field_access_closed</output-dir>
       </compilation-unit>
     </test-case>
+    <test-case FilePath="explain">
+      <compilation-unit name="explain_negative">
+        <output-dir compare="Text">explain_simple</output-dir>
+        <expected-error>ASX1001: Syntax error: EXPLAIN is not supported for this kind of statement</expected-error>
+        <expected-error>ASX1001: Syntax error: EXPLAIN is not supported for this kind of statement</expected-error>
+        <expected-error>ASX1001: Syntax error: EXPLAIN is not supported for this kind of statement</expected-error>
+      </compilation-unit>
+    </test-case>
   </test-group>
   <test-case FilePath="flwor">
     <compilation-unit name="let33">
diff --git a/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj b/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
index c0f1725..5a8b0ea 100644
--- a/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
+++ b/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
@@ -448,8 +448,11 @@
 Statement SingleStatement() throws ParseException:
 {
   Statement stmt = null;
+  boolean explain = false;
+  Token explainToken = null;
 }
 {
+  ( <EXPLAIN> { explain = true; explainToken = token; } )?
   (
     stmt = DataverseDeclaration()
     | stmt = FunctionDeclaration()
@@ -464,11 +467,13 @@
     | stmt = UpsertStatement()
     | stmt = ConnectionStatement()
     | stmt = CompactStatement()
-    | stmt = ExplainStatement()
-    | stmt = Query(false)
+    | stmt = Query(explain)
     | stmt = RefreshExternalDatasetStatement()
   )
   {
+    if (explain && stmt.getKind() != Statement.Kind.QUERY) {
+      throw new SqlppParseException(getSourceLocation(explainToken), "EXPLAIN is not supported for this kind of statement");
+    }
     return stmt;
   }
 }
@@ -1847,17 +1852,6 @@
     FunctionDecl stmt = new FunctionDecl(signature, paramList, funcBody);
     removeCurrentScope();
     return addSourceLocation(stmt, startToken);
-  }
-}
-
-Query ExplainStatement() throws ParseException:
-{
-  Query query;
-}
-{
-  <EXPLAIN> query = Query(true)
-  {
-    return query;
   }
 }
 

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5879/ (14/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Mon, 03 Jun 2019 18:54:54 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9807/ (11/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Sat, 01 Jun 2019 01:09:59 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6082/ (3/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Mon, 03 Jun 2019 18:54:36 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Anon. E. Moose (Code Review)" <de...@asterixdb.apache.org>.
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 1: Contrib-2

Analytics Compatibility Tests Failed
https://cbjenkins.page.link/XFLwdpgyPSELy3nMA : UNSTABLE


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Sat, 01 Jun 2019 02:31:50 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9828/ (10/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jun 2019 15:55:56 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 3: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8649/ : SUCCESS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jun 2019 17:31:06 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Ali Alsuliman (Code Review)" <de...@asterixdb.apache.org>.
Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jun 2019 03:29:09 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5841/ (12/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Mon, 03 Jun 2019 18:54:50 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 1:

BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4470/


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Sat, 01 Jun 2019 01:13:05 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1134/ (6/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Mon, 03 Jun 2019 18:54:39 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/6014/ (3/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Sat, 01 Jun 2019 01:09:50 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5830/ (9/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Sat, 01 Jun 2019 01:09:56 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1123/ (14/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Sat, 01 Jun 2019 01:10:06 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/799/ (16/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Mon, 03 Jun 2019 18:54:57 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5848/ (5/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Sat, 01 Jun 2019 01:09:51 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3858/ (16/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Sat, 01 Jun 2019 01:10:09 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6442/ (5/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Mon, 03 Jun 2019 18:54:38 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1144/ (11/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jun 2019 15:58:45 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3869/ (4/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Mon, 03 Jun 2019 18:54:37 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6071/ (10/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Sat, 01 Jun 2019 01:09:58 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Dmitry Lychagin (Code Review)" <de...@asterixdb.apache.org>.
Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 3: Code-Review+2

Forwarding Ali's +2


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jun 2019 20:10:09 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/650/ (9/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jun 2019 15:55:56 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8629/ : SUCCESS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Sat, 01 Jun 2019 02:24:57 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Anon. E. Moose (Code Review)" <de...@asterixdb.apache.org>.
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 2:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/m943uyzPGT2fLfLo6 : SUCCESS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Mon, 03 Jun 2019 18:58:56 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5866/ (4/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Sat, 01 Jun 2019 01:09:51 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1228/ (2/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Mon, 03 Jun 2019 18:54:36 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/641/ (15/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Mon, 03 Jun 2019 18:54:55 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 3:

Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8649/


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jun 2019 16:19:00 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1038/ (7/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Mon, 03 Jun 2019 18:54:40 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11351/ (13/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Mon, 03 Jun 2019 18:54:52 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6242/ (2/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jun 2019 15:55:55 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6452/ (12/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jun 2019 15:58:59 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6221/ (2/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Sat, 01 Jun 2019 01:09:50 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1237/ (16/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jun 2019 16:19:27 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5776/ (1/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Mon, 03 Jun 2019 18:54:36 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11361/ (8/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jun 2019 15:55:55 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8640/ : SUCCESS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Mon, 03 Jun 2019 20:11:14 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Anon. E. Moose (Code Review)" <de...@asterixdb.apache.org>.
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 3: Contrib+1

Analytics Compatibility Tests Successful
https://cbjenkins.page.link/RKzVyCVxjAprZ7ZP9 : SUCCESS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jun 2019 19:26:40 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/6034/ (15/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jun 2019 16:01:42 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 2: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4483/ : SUCCESS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Mon, 03 Jun 2019 19:14:50 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1048/ (5/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jun 2019 15:55:55 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Dmitry Lychagin (Code Review)" <de...@asterixdb.apache.org>.
Hello Anon. E. Moose (1000171), Till Westmann, Jenkins, 

I'd like you to reexamine a change. Please visit

    https://asterix-gerrit.ics.uci.edu/3420

to look at the new patch set (#2).

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................

[NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Improve error message raised when EXPLAIN
  is not supported for a given statement

Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
---
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.1.ddl.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.2.query.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.3.query.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.4.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/Query.java
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
7 files changed, 153 insertions(+), 19 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/20/3420/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6092/ (13/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jun 2019 15:59:50 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Anon. E. Moose (Code Review)" <de...@asterixdb.apache.org>.
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 1:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/DFCsocfuspPr33e37 : SUCCESS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Sat, 01 Jun 2019 01:14:00 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Anon. E. Moose (Code Review)" <de...@asterixdb.apache.org>.
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 2: Contrib-2

Analytics Compatibility Tests Failed
https://cbjenkins.page.link/XkHVSeLPcjUQPtv16 : UNSTABLE


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Mon, 03 Jun 2019 20:17:48 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5851/ (1/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jun 2019 15:55:54 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Anon. E. Moose (Code Review)" <de...@asterixdb.apache.org>.
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 3:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/tWKZotm3oqTfCHan6 : SUCCESS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jun 2019 16:00:04 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5890/ (3/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jun 2019 15:55:55 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6431/ (12/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Sat, 01 Jun 2019 01:10:01 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 2:

Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8640/


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Mon, 03 Jun 2019 18:58:07 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1217/ (13/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Sat, 01 Jun 2019 01:10:04 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 2:

BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4483/


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Mon, 03 Jun 2019 18:57:54 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5891/ (16/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jun 2019 17:12:48 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9818/ (8/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Mon, 03 Jun 2019 18:54:42 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5859/ (11/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Mon, 03 Jun 2019 18:54:48 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1027/ (15/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Sat, 01 Jun 2019 01:10:07 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Anon. E. Moose (Code Review)" <de...@asterixdb.apache.org>.
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 2:

Analytics Compatibility Tests Failed
https://cbjenkins.page.link/fHV7UZsb13yRWow19 : UNSTABLE


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Mon, 03 Jun 2019 21:52:44 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 1:

Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8629/


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Sat, 01 Jun 2019 01:13:11 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/630/ (6/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Sat, 01 Jun 2019 01:09:52 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Dmitry Lychagin (Code Review)" <de...@asterixdb.apache.org>.
Dmitry Lychagin has submitted this change and it was merged. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................

[NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Improve error message raised when EXPLAIN
  is not supported for a given statement

Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3420
Sonar-Qube: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Dmitry Lychagin <dm...@couchbase.com>
---
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.1.ddl.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.2.query.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.3.query.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.4.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/Query.java
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
7 files changed, 153 insertions(+), 19 deletions(-)

Approvals:
  Jenkins: Verified; No violations found; Verified
  Anon. E. Moose (1000171): 
  Dmitry Lychagin: Looks good to me, approved



diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.1.ddl.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.1.ddl.sqlpp
new file mode 100644
index 0000000..741c9be
--- /dev/null
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.1.ddl.sqlpp
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/*
+ * Description: EXPLAIN not supported for statement kind
+ */
+
+DROP DATAVERSE dvExplain IF EXISTS;
+CREATE DATAVERSE dvExplain;
+
+USE dvExplain;
+
+CREATE TYPE EmployeeType AS {
+  id : string,
+  x  : string
+};
+
+CREATE DATASET Employee(EmployeeType) PRIMARY KEY id;
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.2.query.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.2.query.sqlpp
new file mode 100644
index 0000000..a309a92
--- /dev/null
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.2.query.sqlpp
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/*
+ * Description  : EXPLAIN not supported for CREATE DATAVERSE
+ * Expected Res : Failure
+ */
+
+EXPLAIN CREATE DATAVERSE dvExplain2;
\ No newline at end of file
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.3.query.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.3.query.sqlpp
new file mode 100644
index 0000000..11fe3d2
--- /dev/null
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.3.query.sqlpp
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/*
+ * Description  : EXPLAIN not supported for CREATE DATASET
+ * Expected Res : Failure
+ */
+
+USE dvExplain;
+
+EXPLAIN CREATE DATASET Employee2(EmployeeType) PRIMARY KEY id;
\ No newline at end of file
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.4.query.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.4.query.sqlpp
new file mode 100644
index 0000000..9f74ef8
--- /dev/null
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_negative/explain_negative.4.query.sqlpp
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/*
+ * Description  : EXPLAIN not supported for CREATE INDEX
+ * Expected Res : Failure
+ */
+
+USE dvExplain;
+
+EXPLAIN CREATE INDEX idx1 on Employee(x) type btree;
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
index d1098dc..112277c 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
@@ -174,6 +174,14 @@
         <output-dir compare="Text">explain_field_access_closed</output-dir>
       </compilation-unit>
     </test-case>
+    <test-case FilePath="explain">
+      <compilation-unit name="explain_negative">
+        <output-dir compare="Text">explain_simple</output-dir>
+        <expected-error>ASX1001: Syntax error: EXPLAIN is not supported for this kind of statement</expected-error>
+        <expected-error>ASX1001: Syntax error: EXPLAIN is not supported for this kind of statement</expected-error>
+        <expected-error>ASX1001: Syntax error: EXPLAIN is not supported for this kind of statement</expected-error>
+      </compilation-unit>
+    </test-case>
   </test-group>
   <test-case FilePath="flwor">
     <compilation-unit name="let33">
diff --git a/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/Query.java b/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/Query.java
index 8b67556..7332c7d 100644
--- a/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/Query.java
+++ b/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/Query.java
@@ -30,10 +30,14 @@
 import org.apache.asterix.lang.common.visitor.base.ILangVisitor;
 
 public class Query extends AbstractStatement implements IReturningStatement {
-    private final boolean explain;
+    private boolean explain;
     private boolean topLevel = true;
     private Expression body;
     private int varCounter;
+
+    public Query() {
+        this(false);
+    }
 
     public Query(boolean explain) {
         this.explain = explain;
@@ -80,6 +84,10 @@
         return topLevel;
     }
 
+    public void setExplain(boolean explain) {
+        this.explain = explain;
+    }
+
     public boolean isExplain() {
         return explain;
     }
diff --git a/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj b/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
index 25ad2ab..6f63441 100644
--- a/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
+++ b/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
@@ -434,7 +434,7 @@
 }
 {
   (
-    (stmt = SingleStatement()
+    (stmt = ExplainStatement()
       {
         decls.add(stmt);
       }
@@ -445,6 +445,27 @@
   {
     return decls;
   }
+}
+
+Statement ExplainStatement() throws ParseException:
+{
+  Statement stmt = null;
+  Token explainToken = null;
+}
+{
+   ( <EXPLAIN> { explainToken = token; } )?
+   stmt = SingleStatement()
+   {
+      if (explainToken != null) {
+        if (stmt.getKind() == Statement.Kind.QUERY) {
+          ((Query)stmt).setExplain(true);
+        } else {
+          throw new SqlppParseException(getSourceLocation(explainToken),
+            "EXPLAIN is not supported for this kind of statement");
+        }
+      }
+      return stmt;
+   }
 }
 
 Statement SingleStatement() throws ParseException:
@@ -466,8 +487,7 @@
     | stmt = UpsertStatement()
     | stmt = ConnectionStatement()
     | stmt = CompactStatement()
-    | stmt = ExplainStatement()
-    | stmt = Query(false)
+    | stmt = Query()
     | stmt = RefreshExternalDatasetStatement()
   )
   {
@@ -1090,7 +1110,7 @@
 }
 {
   <INSERT> { startToken = token; } <INTO> nameComponents = QualifiedName() (<AS> var = Variable())?
-    query = Query(false)
+    query = Query()
     ( <RETURNING> returnExpression = Expression())?
     {
       if (var == null && returnExpression != null) {
@@ -1114,7 +1134,7 @@
 }
 {
   <UPSERT> { startToken = token; } <INTO> nameComponents = QualifiedName() (<AS> var = Variable())?
-    query = Query(false)
+    query = Query()
     ( <RETURNING> returnExpression = Expression())?
     {
       if (var == null && returnExpression != null) {
@@ -1852,20 +1872,9 @@
   }
 }
 
-Query ExplainStatement() throws ParseException:
+Query Query() throws ParseException:
 {
-  Query query;
-}
-{
-  <EXPLAIN> query = Query(true)
-  {
-    return query;
-  }
-}
-
-Query Query(boolean explain) throws ParseException:
-{
-  Query query = new Query(explain);
+  Query query = new Query();
   Expression expr;
 }
 {

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 4
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11340/ (8/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Sat, 01 Jun 2019 01:09:53 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5787/ (6/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jun 2019 15:55:55 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/6025/ (10/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Mon, 03 Jun 2019 18:54:46 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6232/ (9/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Mon, 03 Jun 2019 18:54:44 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5868/ (7/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jun 2019 15:55:55 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3879/ (14/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jun 2019 16:00:19 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/811/ (4/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jun 2019 15:55:55 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/788/ (7/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Sat, 01 Jun 2019 01:09:52 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5765/ (1/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Sat, 01 Jun 2019 01:09:50 +0000
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3420 )

Change subject: [NO ISSUE][SQLPP] Improve error message for unsupported EXPLAIN
......................................................................


Patch Set 1: Contrib-2

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4470/ : FAILURE


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3420
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7844ca3d9e3c2c0de0b070e4a76282cb96e278
Gerrit-Change-Number: 3420
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Sat, 01 Jun 2019 01:22:24 +0000
Gerrit-HasComments: No