[GitHub] [lucene] mikemccand commented on a change in pull request #44: LUCENE-9878: enable redundantNullCheck in ecjLint

[GitBox <gi...@apache.org>]

mikemccand commented on a change in pull request #44:
URL: https://github.com/apache/lucene/pull/44#discussion_r602729909



##########
File path: lucene/grouping/src/java/org/apache/lucene/search/grouping/SearchGroup.java
##########
@@ -143,9 +143,9 @@ public boolean equals(Object _other) {
       if (_other instanceof MergedGroup) {
         MergedGroup<?> other = (MergedGroup<?>) _other;
         if (groupValue == null) {
-          return other == null;
+          return other.groupValue == null;

Review comment:
       Wow, this is an awesome catch and shows how useful static analysis is!!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org