[GitHub] [couchdb] willholley opened a new pull request #2412: WIP: fix missing mango execution stats

[GitBox <gi...@apache.org>]

willholley opened a new pull request #2412: WIP: fix missing mango execution stats
URL: https://github.com/apache/couchdb/pull/2412
 
 
   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   
   The previous implementation of Mango execution stats relied on
   passing the docs_examined count from each shard to the coordinator
   in the view_row record. This failed to collect the count of
   documents read which weren't followed by a match (in a given shard).
   For example, if an index was scanned but no documents were matched,
   the docs_examined would be 0, when it should be equal to the number
   of documents in the index.
   
   This commit changes the implementation so that docs examined is passed
   only when each shard has completed its index scan. This requires a new
   handler in fabric so, in it's current state, will generate errors
   in mixed-version clusters (this will need to be addressed before merge).
   
   cc @garrensmith 
   
   ## Testing recommendations
   
   <!-- Describe how we can test your changes.
        Does it provides any behaviour that the end users
        could notice? -->
   
   ## Related Issues or Pull Requests
   
   Discovered whilst testing #2410 
   
   ## Checklist
   
   - [ ] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] willholley merged pull request #2412: Fix missing mango execution stats

[GitBox <gi...@apache.org>]

willholley merged pull request #2412: Fix missing mango execution stats
URL: https://github.com/apache/couchdb/pull/2412
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services