You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2014/08/21 18:46:02 UTC

Review Request 24938: Uncatched exception at ambari agent - it may die on connection error

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24938/
-----------------------------------------------------------

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-6978
    https://issues.apache.org/jira/browse/AMBARI-6978


Repository: ambari


Description
-------

I've got into this situation on 2 agent hosts after I've upgraded ambari-server, reset database and restarted ambari-server few times. Probably there was a rare case when agent got connection exception during registration, and it was not catched. So agent registration failed, and I had to go to agent host and to start agent manually.

DEBUG 2014-08-19 19:02:03,901 security.py:134 - Error in sending/receving data from the server Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/ambari_agent/security.py", line 128, in request
    req.get_data(), req.headers)
  File "/usr/lib64/python2.6/httplib.py", line 920, in request
    self._send_request(method, url, body, headers)
  File "/usr/lib64/python2.6/httplib.py", line 951, in _send_request
    self.endheaders()
  File "/usr/lib64/python2.6/httplib.py", line 908, in endheaders
    self._send_output()
  File "/usr/lib64/python2.6/httplib.py", line 780, in _send_output
    self.send(msg)
  File "/usr/lib64/python2.6/httplib.py", line 739, in send
    self.connect()
  File "/usr/lib/python2.6/site-packages/ambari_agent/security.py", line 53, in connect
    sock = self.create_connection()
  File "/usr/lib/python2.6/site-packages/ambari_agent/security.py", line 94, in create_connection
    sock = socket.create_connection((self.host, self.port), 60)
  File "/usr/lib64/python2.6/socket.py", line 567, in create_connection
    raise error, msg
error: [Errno 111] Connection refused


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/Controller.py 87af939 
  ambari-agent/src/test/python/ambari_agent/TestController.py 9ec23db 

Diff: https://reviews.apache.org/r/24938/diff/


Testing
-------

Agent tests

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 9.358s
[INFO] Finished at: Thu Aug 21 19:42:35 FET 2014
[INFO] Final Memory: 10M/111M
[INFO] ------------------------------------------------------------------------


Thanks,

Dmitro Lisnichenko


Re: Review Request 24938: Uncatched exception at ambari agent - it may die on connection error

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24938/#review51185
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Сер. 21, 2014, 4:46 після полудня, Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24938/
> -----------------------------------------------------------
> 
> (Updated Сер. 21, 2014, 4:46 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6978
>     https://issues.apache.org/jira/browse/AMBARI-6978
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> I've got into this situation on 2 agent hosts after I've upgraded ambari-server, reset database and restarted ambari-server few times. Probably there was a rare case when agent got connection exception during registration, and it was not catched. So agent registration failed, and I had to go to agent host and to start agent manually.
> 
> DEBUG 2014-08-19 19:02:03,901 security.py:134 - Error in sending/receving data from the server Traceback (most recent call last):
>   File "/usr/lib/python2.6/site-packages/ambari_agent/security.py", line 128, in request
>     req.get_data(), req.headers)
>   File "/usr/lib64/python2.6/httplib.py", line 920, in request
>     self._send_request(method, url, body, headers)
>   File "/usr/lib64/python2.6/httplib.py", line 951, in _send_request
>     self.endheaders()
>   File "/usr/lib64/python2.6/httplib.py", line 908, in endheaders
>     self._send_output()
>   File "/usr/lib64/python2.6/httplib.py", line 780, in _send_output
>     self.send(msg)
>   File "/usr/lib64/python2.6/httplib.py", line 739, in send
>     self.connect()
>   File "/usr/lib/python2.6/site-packages/ambari_agent/security.py", line 53, in connect
>     sock = self.create_connection()
>   File "/usr/lib/python2.6/site-packages/ambari_agent/security.py", line 94, in create_connection
>     sock = socket.create_connection((self.host, self.port), 60)
>   File "/usr/lib64/python2.6/socket.py", line 567, in create_connection
>     raise error, msg
> error: [Errno 111] Connection refused
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Controller.py 87af939 
>   ambari-agent/src/test/python/ambari_agent/TestController.py 9ec23db 
> 
> Diff: https://reviews.apache.org/r/24938/diff/
> 
> 
> Testing
> -------
> 
> Agent tests
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 9.358s
> [INFO] Finished at: Thu Aug 21 19:42:35 FET 2014
> [INFO] Final Memory: 10M/111M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>