[GitHub] [superset] michael-s-molina commented on a change in pull request #15141: chore: Scrolls top when opening a select filter

[GitBox <gi...@apache.org>]

michael-s-molina commented on a change in pull request #15141:
URL: https://github.com/apache/superset/pull/15141#discussion_r650989455



##########
File path: superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
##########
@@ -275,14 +292,15 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
         onSearch={searchWrapper}
         onSelect={clearSuggestionSearch}
         onBlur={handleBlur}
-        onDropdownVisibleChange={setIsDropdownVisible}
+        onDropdownVisibleChange={onDropdownVisibleChange}

Review comment:
       I think it's a really great solution. Much more elegant! I'll make the changes and test it. Thank you!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org