You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/02/06 18:01:32 UTC

[GitHub] john-bodley opened a new pull request #4359: [revert] Reverting PR #4062

john-bodley opened a new pull request #4359: [revert] Reverting PR #4062
URL: https://github.com/apache/incubator-superset/pull/4359
 
 
   This PR reverts https://github.com/apache/incubator-superset/pull/4062 which added a MySQL check to the `/health` check. The reason for the revert is two-fold:
   1. I learned that `/health` could return `OK` even if all your requests are failing and the network is down and looking at 5xx errors was a better measure. 
   2. Whilst trying to remove duplicate uniqueness constraints this check caused our instance of Superset to return a 502 which is undesirable. 
   
   to: @graceguo-supercat @mistercrunch @timifasubaa 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services