[GitHub] [spark] francis0407 commented on a change in pull request #23783: [SPARK-26854][SQL] Support ANY/SOME subquery

[GitBox <gi...@apache.org>]

francis0407 commented on a change in pull request #23783: [SPARK-26854][SQL] Support ANY/SOME subquery
URL: https://github.com/apache/spark/pull/23783#discussion_r287597766
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
 ##########
 @@ -548,9 +548,10 @@ object NullPropagation extends Rule[LogicalPlan] {
           Coalesce(newChildren)
         }
 
-      // If the value expression is NULL then transform the In expression to null literal.
+      // If the value expression is NULL then transform the In expression
+      // or PredicateSubquery expression to null literal.
       case In(Literal(null, _), _) => Literal.create(null, BooleanType)
-      case InSubquery(Seq(Literal(null, _)), _) => Literal.create(null, BooleanType)
+      case PredicateSubquery(Seq(Literal(null, _)), _, _) => Literal.create(null, BooleanType)
 
 Review comment:
   This conversion is not correct as I mentioned in https://github.com/apache/spark/pull/24344. But I still keep it here, and will fix this in another PR for [SPARK-27572](https://issues.apache.org/jira/browse/SPARK-27572).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org