You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/01/24 11:52:11 UTC
[GitHub] [druid] kamaci opened a new pull request #10793: Druid tag is set to 0.20.0 which is latest instead of non-existing tag
kamaci opened a new pull request #10793:
URL: https://github.com/apache/druid/pull/10793
Fixes #10792.
### Description
`docker-compose.yml` points Druid version of `0.22.0`. However, latest version in Dockerhub is [0.20.0](https://hub.docker.com/r/apache/druid/tags?page=1&ordering=last_updated). So, you get an image not found error when you try to run project from docker-compose file.
I've changed the version into latest one, `0.20.0` at docker-compose.yml.
<hr>
This PR has:
- [X] been self-reviewed.
- [X] been tested in a test Druid cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
<hr>
##### Key changed/added classes in this PR
* `docker-compose.yml`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #10793: Druid tag is set to 0.20.0 which is latest instead of non-existing tag
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #10793:
URL: https://github.com/apache/druid/pull/10793#issuecomment-786802993
Thanks for fixing this @kamaci - Did you update the versions in the docker-compose file using some command or by hand? If there's a way to automate this - should we add something to our release process so that we always have the latest?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on pull request #10793: Druid tag is set to 0.20.0 which is latest instead of non-existing tag
Posted by GitBox <gi...@apache.org>.
jihoonson commented on pull request #10793:
URL: https://github.com/apache/druid/pull/10793#issuecomment-786820041
@kamaci I understand this is confusing since 0.22.0 is a future version as you pointed out, but the version is intentionally set to 0.22.0 to make all versions in the master branch a sort of in sync (https://github.com/apache/druid/blob/master/distribution/asf-release-process-guide.md#preparing-the-master-branch-for-the-next-version-after-branching). We don't publish snapshot images, so docker compose cannot point snapshots. I thought this is OK because there would not be many people who want to use docker based on master. This means, I don't fully understand why we need this change. Can you elaborate more on your motivation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #10793: Druid tag is set to 0.20.0 which is latest instead of non-existing tag
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #10793:
URL: https://github.com/apache/druid/pull/10793#issuecomment-786803421
Also, sorry for getting around to this so late - I'll be faster on your follow ups to get this in :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] kamaci closed pull request #10793: Druid tag is set to 0.20.0 which is latest instead of non-existing tag
Posted by GitBox <gi...@apache.org>.
kamaci closed pull request #10793:
URL: https://github.com/apache/druid/pull/10793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on a change in pull request #10793: Druid tag is set to 0.20.0 which is latest instead of non-existing tag
Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #10793:
URL: https://github.com/apache/druid/pull/10793#discussion_r583818851
##########
File path: distribution/docker/docker-compose.yml
##########
@@ -46,7 +46,7 @@ services:
- ZOO_MY_ID=1
coordinator:
- image: apache/druid:0.22.0
+ image: apache/druid:0.20.0
Review comment:
Should we update this to `0.20.1` - now that the latest release was updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org