You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/05/05 14:09:13 UTC
[GitHub] [ignite-3] sashapolo opened a new pull request #119: IGNITE-14682 Fix sending messages from a node to itself
sashapolo opened a new pull request #119:
URL: https://github.com/apache/ignite-3/pull/119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sashapolo commented on a change in pull request #119: IGNITE-14682 Fix sending messages from a node to itself
Posted by GitBox <gi...@apache.org>.
sashapolo commented on a change in pull request #119:
URL: https://github.com/apache/ignite-3/pull/119#discussion_r626615988
##########
File path: modules/network/src/integrationTest/java/org/apache/ignite/network/scalecube/ITScaleCubeNetworkMessagingTest.java
##########
@@ -48,6 +48,11 @@
/** */
class ITScaleCubeNetworkMessagingTest {
+ /**
+ * Test cluster.
+ * <p>
Review comment:
why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov merged pull request #119: IGNITE-14682 Fix sending messages from a node to itself
Posted by GitBox <gi...@apache.org>.
ibessonov merged pull request #119:
URL: https://github.com/apache/ignite-3/pull/119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] SammyVimes commented on a change in pull request #119: IGNITE-14682 Fix sending messages from a node to itself
Posted by GitBox <gi...@apache.org>.
SammyVimes commented on a change in pull request #119:
URL: https://github.com/apache/ignite-3/pull/119#discussion_r626636206
##########
File path: modules/network/src/integrationTest/java/org/apache/ignite/network/scalecube/ITScaleCubeNetworkMessagingTest.java
##########
@@ -48,6 +48,11 @@
/** */
class ITScaleCubeNetworkMessagingTest {
+ /**
+ * Test cluster.
+ * <p>
Review comment:
Hm, I always thought that p requires a closing tag or at least it should be self-closing. Ok then)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sashapolo commented on a change in pull request #119: IGNITE-14682 Fix sending messages from a node to itself
Posted by GitBox <gi...@apache.org>.
sashapolo commented on a change in pull request #119:
URL: https://github.com/apache/ignite-3/pull/119#discussion_r626615988
##########
File path: modules/network/src/integrationTest/java/org/apache/ignite/network/scalecube/ITScaleCubeNetworkMessagingTest.java
##########
@@ -48,6 +48,11 @@
/** */
class ITScaleCubeNetworkMessagingTest {
+ /**
+ * Test cluster.
+ * <p>
Review comment:
why? Even JDK's javadocs don't have them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] SammyVimes commented on a change in pull request #119: IGNITE-14682 Fix sending messages from a node to itself
Posted by GitBox <gi...@apache.org>.
SammyVimes commented on a change in pull request #119:
URL: https://github.com/apache/ignite-3/pull/119#discussion_r626609578
##########
File path: modules/network/src/integrationTest/java/org/apache/ignite/network/scalecube/ITScaleCubeNetworkMessagingTest.java
##########
@@ -48,6 +48,11 @@
/** */
class ITScaleCubeNetworkMessagingTest {
+ /**
+ * Test cluster.
+ * <p>
Review comment:
`p` should have a closing tag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org