You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2010/02/01 14:10:16 UTC

[Bug 6316] New: DCC.pm, wrong options for dcc_proc

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6316

           Summary: DCC.pm, wrong options for dcc_proc
           Product: Spamassassin
           Version: 3.3.0
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Plugins
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: scheidell@secnap.net


Created an attachment (id=4665)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4665)
patch to change dcc_options back.

was using this on SA 3.2.5 in local.cf
dcc_options -R -x 0
dcc_home /usr/local/dcc
dcc_dccifd_path /usr/local/dcc/dccifd

now, on SA 3.30, I get this (constantly).

Feb  1 07:19:14 mx1 dccifd[10069]: unrecognized option value: "-R -x 0"

note, that dcc_options are options that are supposed to be sent to the dccproc
command, NOT dccifd. 

Mark suggests this patch, which seems to work in my case.
(note for googlers, -x 0 is already in the defaults, you don't need it)

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6316] [review] DCC.pm, wrong options for dcc_proc

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6316

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kmcgrail@pccc.com

--- Comment #2 from Kevin A. McGrail <km...@pccc.com> 2010-02-03 10:42:33 UTC ---
I'm +1 on the patch.  

However, my concern is that the change for the options var might be more
pervasive.  Why was this changed previously?

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6316] [review] DCC.pm, wrong options for dcc_proc

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6316

--- Comment #3 from Mark Martinec <Ma...@ijs.si> 2010-02-03 10:47:41 UTC ---
(In reply to comment #2)
> I'm +1 on the patch.  

Thanks.

> However, my concern is that the change for the options var might be more
> pervasive.  Why was this changed previously?

Not intentionally, my cut/paste error during overhaul of this plugin.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6316] DCC.pm, wrong options for dcc_proc

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6316

--- Comment #1 from Mark Martinec <Ma...@ijs.si> 2010-02-01 05:24:08 UTC ---
  Bug 6316 - DCC.pm, wrong options for dcc_proc
  (plus: avoid a warning on undef in logger when
  dccifd socket is not provided)
Sending lib/Mail/SpamAssassin/Plugin/DCC.pm
Committed revision 905275.

Please review/vote for:  svn diff -c905275

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6316] [review] DCC.pm, wrong options for dcc_proc

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6316

Karsten Bräckelmann <gu...@rudersport.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|needs 1 vote                |ready for commit

--- Comment #5 from Karsten Bräckelmann <gu...@rudersport.de> 2010-02-03 11:15:46 UTC ---
+1

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6316] [review] DCC.pm, wrong options for dcc_proc

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6316

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|DCC.pm, wrong options for   |[review] DCC.pm, wrong
                   |dcc_proc                    |options for dcc_proc
  Status Whiteboard|                            |needs 2 votes

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6316] [review] DCC.pm, wrong options for dcc_proc

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6316

--- Comment #4 from Kevin A. McGrail <km...@pccc.com> 2010-02-03 10:51:07 UTC ---
Thanks.  Saved me from the witch-hunt of looking for other references that were
wrong.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6316] DCC.pm, wrong options for dcc_proc

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6316

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5                          |P3
   Target Milestone|Undefined                   |3.3.1

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6316] [review] DCC.pm, wrong options for dcc_proc

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6316

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6316] [review] DCC.pm, wrong options for dcc_proc

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6316

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Mark Martinec <Ma...@ijs.si> 2010-02-03 11:24:56 UTC ---
Thanks!

3.3:
  Bug 6316: DCC.pm, wrong options for dcc_proc,
  (plus: avoid a warning on undef in logger when
  dccifd socket is not provided)
Sending lib/Mail/SpamAssassin/Plugin/DCC.pm
Committed revision 906193.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6316] [review] DCC.pm, wrong options for dcc_proc

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6316

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|needs 2 votes               |needs 1 vote

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.