You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Patrick0308 (GitHub)" <gi...@apache.org> on 2020/02/07 13:08:42 UTC
[GitHub] [dubbo-go] Patrick0308 opened pull request #353: Fix rest
protocol issue
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
[ Full content available at: https://github.com/apache/dubbo-go/pull/353 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] flycash closed pull request #353: Fix rest
protocol issue
Posted by "flycash (GitHub)" <gi...@apache.org>.
[ pull request closed by flycash ]
[ Full content available at: https://github.com/apache/dubbo-go/pull/353 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #353: Fix rest
protocol issue
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/353?src=pr&el=h1) Report
> Merging [#353](https://codecov.io/gh/apache/dubbo-go/pull/353?src=pr&el=desc) into [feature/rest](https://codecov.io/gh/apache/dubbo-go/commit/a957054a32f82791029ac0e2a2f462c93af26e0b?src=pr&el=desc) will **increase** coverage by `0.11%`.
> The diff coverage is `92.3%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/353/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/rest #353 +/- ##
===============================================
+ Coverage 66.78% 66.9% +0.11%
===============================================
Files 128 128
Lines 7877 7877
===============================================
+ Hits 5261 5270 +9
+ Misses 2098 2088 -10
- Partials 518 519 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/rest/rest\_config\_initializer.go](https://codecov.io/gh/apache/dubbo-go/pull/353/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X2NvbmZpZ19pbml0aWFsaXplci5nbw==) | `82.5% <100%> (ø)` | :arrow_up: |
| [protocol/rest/rest\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/353/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X3Byb3RvY29sLmdv) | `93.65% <80%> (ø)` | :arrow_up: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/353/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `51.51% <0%> (+1.01%)` | :arrow_up: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/353/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `72.46% <0%> (+10.14%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/353?src=pr&el=footer). Last update [a957054...b67b76a](https://codecov.io/gh/apache/dubbo-go/pull/353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/353 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org