[GitHub] [incubator-doris] morningman commented on a change in pull request #5022: Push down predicate on value column of unique table to base rowset

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #5022:
URL: https://github.com/apache/incubator-doris/pull/5022#discussion_r535901555



##########
File path: be/src/exec/olap_scanner.cpp
##########
@@ -164,8 +164,14 @@ Status OlapScanner::_init_params(const std::vector<OlapScanRange*>& key_ranges,
     // TODO(zc)
     _params.profile = _profile;
     _params.runtime_state = _runtime_state;
-
-    if (_aggregation) {
+    bool single_version =

Review comment:
       Better add comment to explain the logic here.
   The fact that "version[0-1] has no data" is a very tricky and important reason, should let other code reviewers know.

##########
File path: be/src/olap/rowset/rowset_reader_context.h
##########
@@ -47,6 +47,8 @@ struct RowsetReaderContext {
     // column name -> column predicate
     // adding column_name for predicate to make use of column selectivity
     const std::vector<ColumnPredicate*>* predicates = nullptr;
+    // value column predicate in AGG/UNIQUE table

Review comment:
       ```suggestion
       // value column predicate in UNIQUE table
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org